Git development
 help / color / mirror / Atom feed
From: Greg Bacon <gbacon@dbresearch.net>
To: Thomas Rast <trast@student.ethz.ch>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] No diff -b/-w output for all-whitespace changes
Date: Thu, 19 Nov 2009 16:25:14 -0600	[thread overview]
Message-ID: <4B05C5CA.6090408@dbresearch.net> (raw)
In-Reply-To: <200911192314.41542.trast@student.ethz.ch>

Thomas Rast wrote

> Judging from the test, this parses as
> 
>   Change git-diff's whitespace-ignoring modes to generate
>   output only if a non-(empty patch, which git-apply
>   rejects) results.
> 
> which is a bit weird, isn't it? :-)

Yes, rotten wording. I meant git-apply rejects empty patches,
so let's not do that!

I chose this route rather than making git-apply more
forgiving because as currently implemented, git-diff is not
entirely ignoring whitespace when commanded to do so.

Greg

      reply	other threads:[~2009-11-19 22:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 21:12 [PATCH] No diff -b/-w output for all-whitespace changes Greg Bacon
2009-11-19 22:06 ` Junio C Hamano
2009-11-19 22:14 ` Thomas Rast
2009-11-19 22:25   ` Greg Bacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B05C5CA.6090408@dbresearch.net \
    --to=gbacon@dbresearch.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox