Git development
 help / color / mirror / Atom feed
* [PATCH] Fix typo in filter-branch example
@ 2009-08-13 16:16 Ori Avtalion
  2009-08-13 16:36 ` Michael J Gruber
  2009-08-13 17:04 ` Johannes Schindelin
  0 siblings, 2 replies; 4+ messages in thread
From: Ori Avtalion @ 2009-08-13 16:16 UTC (permalink / raw)
  To: git

---
 Documentation/git-filter-branch.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
index ab527b5..8cda87c 100644
--- a/Documentation/git-filter-branch.txt
+++ b/Documentation/git-filter-branch.txt
@@ -336,7 +336,7 @@ To move the whole tree into a subdirectory, or remove it from there:
 
 ---------------------------------------------------------------
 git filter-branch --index-filter \
-	'git ls-files -s | sed "s-\t-&newsubdir/-" |
+	'git ls-files -s | sed "s-\t-\tnewsubdir/-" |
 		GIT_INDEX_FILE=$GIT_INDEX_FILE.new \
 			git update-index --index-info &&
 	 mv $GIT_INDEX_FILE.new $GIT_INDEX_FILE' HEAD
-- 
1.6.4.114.gefd1.dirty

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix typo in filter-branch example
  2009-08-13 16:16 [PATCH] Fix typo in filter-branch example Ori Avtalion
@ 2009-08-13 16:36 ` Michael J Gruber
  2009-08-13 17:04 ` Johannes Schindelin
  1 sibling, 0 replies; 4+ messages in thread
From: Michael J Gruber @ 2009-08-13 16:36 UTC (permalink / raw)
  To: Ori Avtalion; +Cc: git

Ori Avtalion venit, vidit, dixit 13.08.2009 18:16:
> ---
>  Documentation/git-filter-branch.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/git-filter-branch.txt b/Documentation/git-filter-branch.txt
> index ab527b5..8cda87c 100644
> --- a/Documentation/git-filter-branch.txt
> +++ b/Documentation/git-filter-branch.txt
> @@ -336,7 +336,7 @@ To move the whole tree into a subdirectory, or remove it from there:
>  
>  ---------------------------------------------------------------
>  git filter-branch --index-filter \
> -	'git ls-files -s | sed "s-\t-&newsubdir/-" |
> +	'git ls-files -s | sed "s-\t-\tnewsubdir/-" |
>  		GIT_INDEX_FILE=$GIT_INDEX_FILE.new \
>  			git update-index --index-info &&
>  	 mv $GIT_INDEX_FILE.new $GIT_INDEX_FILE' HEAD

If \t is matched then isn't & == \t?

Michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix typo in filter-branch example
  2009-08-13 16:16 [PATCH] Fix typo in filter-branch example Ori Avtalion
  2009-08-13 16:36 ` Michael J Gruber
@ 2009-08-13 17:04 ` Johannes Schindelin
  2009-08-13 17:15   ` Ori Avtalion
  1 sibling, 1 reply; 4+ messages in thread
From: Johannes Schindelin @ 2009-08-13 17:04 UTC (permalink / raw)
  To: Ori Avtalion; +Cc: git

Hi,

On Thu, 13 Aug 2009, Ori Avtalion wrote:

> ---

This is not a typo. '&' is sed's way to specify the matched string.  Where 
does it occur anyway (the commit message makes a fabulous place to put 
such information)?

Ciao,
Dscho

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Fix typo in filter-branch example
  2009-08-13 17:04 ` Johannes Schindelin
@ 2009-08-13 17:15   ` Ori Avtalion
  0 siblings, 0 replies; 4+ messages in thread
From: Ori Avtalion @ 2009-08-13 17:15 UTC (permalink / raw)
  To: Johannes Schindelin; +Cc: git, Michael J Gruber

On 08/13/2009 08:04 PM, Johannes Schindelin wrote:
>
> This is not a typo. '&' is sed's way to specify the matched string.  Where
> does it occur anyway (the commit message makes a fabulous place to put
> such information)?

Whoops! My mistake!

I think I accidentally removed it when I tried the example, and then 
added it in a wrong position when that didn't work :)

Sorry for the false alarm!

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-08-13 17:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-13 16:16 [PATCH] Fix typo in filter-branch example Ori Avtalion
2009-08-13 16:36 ` Michael J Gruber
2009-08-13 17:04 ` Johannes Schindelin
2009-08-13 17:15   ` Ori Avtalion

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox