From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>, git@vger.kernel.org
Cc: "Patrick Steinhardt" <ps@pks.im>
Subject: Re: [PATCH v2 0/5] stash completion miscellany
Date: Fri, 23 Oct 2026 16:33:22 +0200 [thread overview]
Message-ID: <4f14a14a-99a9-4a01-bbab-ee1630e109f6@app.fastmail.com> (raw)
In-Reply-To: <cover.1792761643.git.ben.knoble@gmail.com>
On Fri, Oct 23, 2026, at 15:20, D. Ben Knoble wrote:
> This short patch series takes care of a few paper cuts in stash
> completion. The first patch is a small code cleanup I noticed a while
> back while working on bfc1b34859 (completion: add stash import, export,
> 2026-02-07), I think. The next 2 take care of a problem I've been having
> with Zsh's completion of stashes (cf. Unix & Linux SE [1]).
>
> [1]: https://unix.stackexchange.com/q/807580/301073
>
>[snip]
>
> Generated-with: git format-patch @{u}.. -o p -v2
> --range-diff=@{u}..d1d0bf2d9a7d380d10771b5d1bceb8db91c5f05e
> --in-reply-to=cover.1791827304.git.ben.knoble@gmail.com --cc='Patrick
> Steinhardt <ps@pks.im>'
>
> I accidentally left the above line in v1, but I'm considering leaving it in from
> now on?
;)
> It's the exact command I run to generate patches; I store it as a
> "trailer" in the branch description, then run "git generated-with"† which
> (effectively) does
>
> eval "$(git bdesc | git interpret-trailers --parse | grep
> ^Generated-with | cut -d: -f 2-)"
>
> where "bdesc" is an alias for
>
> git -c core.editor=cat branch --edit-description | git stripspace -s
>
> Anyway, I've been hand-editing them out of cover letters for the last few
> series, but if it doesn't bother anyone I'll just leave it around. Might be
> helpful for new folks learning how to format patches?
I think it’s a decent-to-good idea to leave it in.
>
> †:
> https://github.com/benknoble/Dotfiles/blob/master/links/bin/git-generated-with
>[snip]
next prev parent reply other threads:[~2026-10-23 14:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 17:48 [PATCH 0/5] stash completion miscellany D. Ben Knoble
2026-10-12 17:48 ` [PATCH 1/5] completion: simplify stash subcommand completion D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 19:58 ` Ben Knoble
2026-10-12 17:48 ` [PATCH 2/5] completion: extract common stash listing code D. Ben Knoble
2026-10-12 17:48 ` [PATCH 3/5] completion: fix Zsh handling of stash names D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 19:56 ` Ben Knoble
2026-10-12 17:48 ` [PATCH 4/5] doc: drop usage mentions of "git stash save" D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-12 17:48 ` [PATCH 5/5] completion: drop "stash save" completion altogether D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 20:01 ` Ben Knoble
2026-10-20 6:05 ` Patrick Steinhardt
2026-10-22 13:14 ` D. Ben Knoble
2026-10-23 6:21 ` Patrick Steinhardt
2026-10-23 13:20 ` [PATCH v2 0/5] stash completion miscellany D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 1/5] completion: simplify stash subcommand completion D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 2/5] Completion: extract common stash listing code D. Ben Knoble
2026-10-23 17:06 ` Junio C Hamano
2026-10-23 13:20 ` [PATCH v2 3/5] completion: fix Zsh handling of stash names D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 4/5] doc: drop usage mentions of "git stash save" D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 5/5] completion: drop "stash save" completion altogether D. Ben Knoble
2026-10-23 17:06 ` Junio C Hamano
2026-10-23 18:07 ` Ben Knoble
2026-10-23 14:33 ` Kristoffer Haugsbakk [this message]
2026-10-26 8:48 ` [PATCH v2 0/5] stash completion miscellany Patrick Steinhardt
2026-10-26 14:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f14a14a-99a9-4a01-bbab-ee1630e109f6@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox