From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble" <ben.knoble@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2 2/5] Completion: extract common stash listing code
Date: Fri, 23 Oct 2026 10:06:32 -0700 [thread overview]
Message-ID: <xmqqjyn88hyf.fsf@gitster.g> (raw)
In-Reply-To: <abf8efb792e6cc90db2752baaef4a7bb1d00f4b1.1792761643.git.ben.knoble@gmail.com> (D. Ben Knoble's message of "Fri, 23 Oct 2026 09:20:52 -0400")
"D. Ben Knoble" <ben.knoble@gmail.com> writes:
> With no change in behavior, prepare to adjust how stashes are completed
> by centralizing candidate generation.
>
> Signed-off-by: D. Ben Knoble <ben.knoble@gmail.com>
> ---
> contrib/completion/git-completion.bash | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
> @@ -3593,20 +3593,23 @@ _git_stash ()
> if [ $cword -eq $((__git_cmd_idx+2)) ]; then
> __git_complete_refs
> else
> - __gitcomp_nl "$(__git stash list \
> - | sed -n -e 's/:.*//p')"
> + __git_complete_stashes
> ...
> - __gitcomp_nl "$(__git stash list \
> - | sed -n -e 's/:.*//p')"
> + __git_complete_stashes
Nice to see two of these unsightly constructs go ;-)
next prev parent reply other threads:[~2026-10-23 17:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 17:48 [PATCH 0/5] stash completion miscellany D. Ben Knoble
2026-10-12 17:48 ` [PATCH 1/5] completion: simplify stash subcommand completion D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 19:58 ` Ben Knoble
2026-10-12 17:48 ` [PATCH 2/5] completion: extract common stash listing code D. Ben Knoble
2026-10-12 17:48 ` [PATCH 3/5] completion: fix Zsh handling of stash names D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 19:56 ` Ben Knoble
2026-10-12 17:48 ` [PATCH 4/5] doc: drop usage mentions of "git stash save" D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-12 17:48 ` [PATCH 5/5] completion: drop "stash save" completion altogether D. Ben Knoble
2026-10-16 8:01 ` Patrick Steinhardt
2026-10-19 20:01 ` Ben Knoble
2026-10-20 6:05 ` Patrick Steinhardt
2026-10-22 13:14 ` D. Ben Knoble
2026-10-23 6:21 ` Patrick Steinhardt
2026-10-23 13:20 ` [PATCH v2 0/5] stash completion miscellany D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 1/5] completion: simplify stash subcommand completion D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 2/5] Completion: extract common stash listing code D. Ben Knoble
2026-10-23 17:06 ` Junio C Hamano [this message]
2026-10-23 13:20 ` [PATCH v2 3/5] completion: fix Zsh handling of stash names D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 4/5] doc: drop usage mentions of "git stash save" D. Ben Knoble
2026-10-23 13:20 ` [PATCH v2 5/5] completion: drop "stash save" completion altogether D. Ben Knoble
2026-10-23 17:06 ` Junio C Hamano
2026-10-23 18:07 ` Ben Knoble
2026-10-23 14:33 ` [PATCH v2 0/5] stash completion miscellany Kristoffer Haugsbakk
2026-10-26 8:48 ` Patrick Steinhardt
2026-10-26 14:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqjyn88hyf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox