Git development
 help / color / mirror / Atom feed
* [PATCH] remote-curl.c: Fix a gcc warning
@ 2012-11-10 18:34 Ramsay Jones
  0 siblings, 0 replies; only message in thread
From: Ramsay Jones @ 2012-11-10 18:34 UTC (permalink / raw)
  To: Jeff King; +Cc: GIT Mailing-list


In particular, gcc complains as follows:

        CC remote-curl.o
    remote-curl.c: In function `rpc_service':
    remote-curl.c:403: warning: 'gzip_size' might be used uninitialized \
        in this function

The 'gzip_size' variable would not, in fact, be used uninitialized.
However, in order to suppress the warning, we simply initialize the
variable to zero in it's declaration.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Jeff,

Could you please squash this into commit df126e108 ("remote-curl: hoist
gzip buffer size to top of post_rpc", 31-10-2012), which is part of
your 'jk/maint-http-half-auth-fetch' branch.

Thanks!

ATB,
Ramsay Jones

 remote-curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/remote-curl.c b/remote-curl.c
index d8b3600..9a8b123 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -400,7 +400,7 @@ static int post_rpc(struct rpc_state *rpc)
 	struct curl_slist *headers = NULL;
 	int use_gzip = rpc->gzip_request;
 	char *gzip_body = NULL;
-	size_t gzip_size;
+	size_t gzip_size = 0;
 	int err, large_request = 0;
 
 	/* Try to load the entire request, if we can fit it into the
-- 
1.8.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2012-11-10 18:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-10 18:34 [PATCH] remote-curl.c: Fix a gcc warning Ramsay Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox