Git development
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: "Junio C Hamano" <gitster@pobox.com>,
	"Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t0027: Add repoMIX and LF_nul
Date: Sat, 25 Apr 2015 23:43:55 +0200	[thread overview]
Message-ID: <553C0A9B.7060407@web.de> (raw)
In-Reply-To: <xmqqegn817pr.fsf@gitster.dls.corp.google.com>

On 2015-04-25 18.41, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> "new safer autocrlf handling":
>>   Check if eols in a file are converted at commit, when the file has
>>   CR (or CLLF) in the repo (technically speaking in the index).
> 
> s/CLLF/CRLF/?  (no need to resend for this; I'll locally amend)
> 
>>   Add a test-file repoMIX with mixed line-endings.
>>   When converting LF->CRLF or CRLF->LF: check the warnings
>>
>> checkout_files():
>>   Checking out CRLF_nul and checking for eol coversion does not
>>   make much sense (CRLF will stay CRLF).
> 
> Hmph, would it still make sense to make sure that CRLF will stay CRLF
> so that future changes to break this expectation can be caught?  Not
> that such a breakage is likely...

Thanks for amending.

We have the file CRLF (and CRLFmixLF), where we check that CRLF stays CRLF and is not
converted into CRLFLF.

The LF_nul is to test the "auto text detection":
It should not be converted into CRLF_nul in "auto mode",
but should be converted when declared as "text" in .gitattributes.

  reply	other threads:[~2015-04-25 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-25  6:47 [PATCH v2] t0027: Add repoMIX and LF_nul Torsten Bögershausen
2015-04-25 15:13 ` Johannes Schindelin
2015-04-25 16:41 ` Junio C Hamano
2015-04-25 21:43   ` Torsten Bögershausen [this message]
2015-04-26  4:32     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553C0A9B.7060407@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox