From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t0027: Add repoMIX and LF_nul
Date: Sat, 25 Apr 2015 21:32:32 -0700 [thread overview]
Message-ID: <xmqqbnibzezj.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <553C0A9B.7060407@web.de> ("Torsten Bögershausen"'s message of "Sat, 25 Apr 2015 23:43:55 +0200")
Torsten Bögershausen <tboegi@web.de> writes:
>> Hmph, would it still make sense to make sure that CRLF will stay CRLF
>> so that future changes to break this expectation can be caught? Not
>> that such a breakage is likely...
>
> Thanks for amending.
>
> We have the file CRLF (and CRLFmixLF), where we check that CRLF stays CRLF and is not
> converted into CRLFLF.
>
> The LF_nul is to test the "auto text detection":
> It should not be converted into CRLF_nul in "auto mode",
> but should be converted when declared as "text" in .gitattributes.
The two paragraphs above may explain why the test would pass with
the current code, but is that sufficient assurance that other people
in future changes would not break the "It should not be" with their
bugs that you do not foresee at this moment? Whenever you say "it
should not be", I hear "if the code somehow does that, somebody
broke our code", which in turn suggests me that catching that
condition with tests is a good thing.
Or am I hearing you incorrectly?
prev parent reply other threads:[~2015-04-26 4:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-25 6:47 [PATCH v2] t0027: Add repoMIX and LF_nul Torsten Bögershausen
2015-04-25 15:13 ` Johannes Schindelin
2015-04-25 16:41 ` Junio C Hamano
2015-04-25 21:43 ` Torsten Bögershausen
2015-04-26 4:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnibzezj.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox