Re: [PATCH 2/2] unit-tests: ignore --long-tests

[Kaartic Sivaraam <kaartic.sivaraam@gmail.com>]

On 10/23/26 12:20, Patrick Steinhardt wrote:
>>
>>    $ meson test -v --test-args='-ilx'
>>
>> So, ignore -l / --long-tests in our clar tests.
> 
> TIL, I didn't even know we had this switch to run long tests. That makes
> me wonder whether we should have an "--features-testbed" switch to make
> it easy to run tests same as our CI job that sets all those test
> variables, and then adapt CI to use it. It's always a pain to specify
> all of these environment variables.
> 

That would indeed be a good addition! It may help us easily emulate the 
feature-testbed job locally. I say "easy" hoping it does not need any 
kind of additional niche dependency in order to run locally. It seems so 
on taking a quick look at the the CI script :-)

> That's of course outside of the scope of this patch series, but I've got
> a pending series where I may be able to squeeze this into.
> 

Cool!

>> This does not show up as a problem while running our CI as we enable
>> the expensive prerequiiste via the GIT_TEST_LONG env variable.
> 
> s/prerequiiste/prerequisite/
>

Good catch. Will fix this!
>> diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
>> index d066c8a4c8..06ffd0f5bb 100644
>> --- a/t/unit-tests/unit-test.c
>> +++ b/t/unit-tests/unit-test.c
>> @@ -28,6 +28,7 @@ int cmd_main(int argc, const char **argv)
>>   		 */
>>   		OPT_NOOP_NOARG('d', "debug"),
>>   		OPT_NOOP_NOARG(0, "github-workflow-markup"),
>> +		OPT_NOOP_NOARG('l', "long-tests"),
>>   		OPT_NOOP_NOARG(0, "no-bin-wrappers"),
>>   		OPT_NOOP_ARG(0, "no-chain-lint"),
>>   		OPT_NOOP_ARG(0, "root"),
> 
> Looks obviously good to me, thanks!
>

Thanks for the prompt review!

-- 
Sivaraam