Git development
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] unit-tests: reshuffle NOOP arguments to maintain order
Date: Fri, 23 Oct 2026 08:50:32 +0200	[thread overview]
Message-ID: <atsDuCBc5J2lXOuU@pks.im> (raw)
In-Reply-To: <20261022-ks-unit-tests-ignore-long-tests-v1-1-554a590d418b@gmail.com>

On Thu, Oct 22, 2026 at 04:31:57PM +0530, Kaartic Sivaraam wrote:
> diff --git a/t/unit-tests/unit-test.c b/t/unit-tests/unit-test.c
> index 752fb38fb3..d066c8a4c8 100644
> --- a/t/unit-tests/unit-test.c
> +++ b/t/unit-tests/unit-test.c
> @@ -33,12 +33,12 @@ int cmd_main(int argc, const char **argv)
>  		OPT_NOOP_ARG(0, "root"),
>  		OPT_NOOP_ARG(0, "stress"),
>  		OPT_NOOP_NOARG(0, "tee"),
> -		OPT_NOOP_NOARG(0, "with-dashes"),
>  		OPT_NOOP_ARG(0, "valgrind"),
>  		OPT_NOOP_ARG(0, "valgrind-only"),
>  		OPT_NOOP_NOARG('v', "verbose"),
>  		OPT_NOOP_NOARG('V', "verbose-log"),
>  		OPT_NOOP_ARG(0, "verbose-only"),
> +		OPT_NOOP_NOARG(0, "with-dashes"),
>  		OPT_NOOP_NOARG('x', NULL),
>  		OPT_END(),
>  	};

Makes sense, and the list is indeed sorted after this change.

Patrick

  reply	other threads:[~2026-10-23  6:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 11:01 [PATCH 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-22 11:01 ` [PATCH 1/2] unit-tests: reshuffle NOOP arguments to maintain order Kaartic Sivaraam
2026-10-23  6:50   ` Patrick Steinhardt [this message]
2026-10-22 11:01 ` [PATCH 2/2] unit-tests: ignore --long-tests Kaartic Sivaraam
2026-10-23  6:50   ` Patrick Steinhardt
2026-10-23  7:15     ` Kaartic Sivaraam
2026-10-26  7:31 ` [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Kaartic Sivaraam
2026-10-26  7:31   ` [PATCH v2 1/2] unit-tests: reshuffle NOOP arguments to maintain order Kaartic Sivaraam
2026-10-26  7:31   ` [PATCH v2 2/2] unit-tests: ignore --long-tests Kaartic Sivaraam
2026-10-26  8:11   ` [PATCH v2 0/2] Make our clar tests ignore the long-tests argument Patrick Steinhardt
2026-10-26 16:10     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atsDuCBc5J2lXOuU@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=kaartic.sivaraam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox