From: "Jason Pyeron" <jpyeron@pdinc.us>
To: "'Junio C Hamano'" <gitster@pobox.com>,
"'brian m. carlson'" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>
Subject: RE: Conventions on struct copying?
Date: Thu, 19 Jun 2014 13:22:44 -0400 [thread overview]
Message-ID: <5A7F0CEE2DEC4F1B825568DB8358D397@black> (raw)
In-Reply-To: <xmqqvbrwhlki.fsf@gitster.dls.corp.google.com>
> -----Original Message-----
> From: Junio C Hamano
> Sent: Thursday, June 19, 2014 13:11
>
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
> > I don't know of any place we explicitly copy structs like
> > this,...
>
> which should be a reason enough. The first concrete guideline is
> "just imitate the existing code".
>
> > but I don't know of any prohibition against it, either.
>
> So now you know ;-).
To expand, on that do not trust the compiler to do deep copies.
http://stackoverflow.com/questions/2302351/assign-one-struct-to-another-in-c
Hit #1 on https://www.google.com/search?q=c+assignment+of+struct
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
- -
- Jason Pyeron PD Inc. http://www.pdinc.us -
- Principal Consultant 10 West 24th Street #100 -
- +1 (443) 269-1555 x333 Baltimore, Maryland 21218 -
- -
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
This message is copyright PD Inc, subject to license 20080407P00.
next prev parent reply other threads:[~2014-06-19 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 23:31 Conventions on struct copying? brian m. carlson
2014-06-19 17:10 ` Junio C Hamano
2014-06-19 17:22 ` Jason Pyeron [this message]
2014-06-20 1:26 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A7F0CEE2DEC4F1B825568DB8358D397@black \
--to=jpyeron@pdinc.us \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox