Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org
Subject: Re: Conventions on struct copying?
Date: Thu, 19 Jun 2014 10:10:37 -0700	[thread overview]
Message-ID: <xmqqvbrwhlki.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140618233129.GK368384@vauxhall.crustytoothpaste.net> (brian m. carlson's message of "Wed, 18 Jun 2014 23:31:29 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I don't know of any place we explicitly copy structs like
> this,...

which should be a reason enough.  The first concrete guideline is
"just imitate the existing code".

> but I don't know of any prohibition against it, either.

So now you know ;-).

  reply	other threads:[~2014-06-19 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18 23:31 Conventions on struct copying? brian m. carlson
2014-06-19 17:10 ` Junio C Hamano [this message]
2014-06-19 17:22   ` Jason Pyeron
2014-06-20  1:26     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvbrwhlki.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox