* [PATCH] pkt-line: mark a file-local symbol static
@ 2016-09-14 13:31 Ramsay Jones
2016-09-15 16:46 ` Lars Schneider
0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2016-09-14 13:31 UTC (permalink / raw)
To: Lars Schneider; +Cc: Junio C Hamano, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Lars,
If you need to re-roll your 'ls/filter-process' branch, could you
please squash this into the relevant patch; commit 2afd9b22
("pkt-line: add packet_write_gently()", 08-09-2016).
[If you think the symbol should be public (I don't), then add a
suitable declaration to pkt-line.h instead.]
Thanks!
ATB,
Ramsay Jones
pkt-line.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index 538e35f..4900fc0 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...)
return status;
}
-int packet_write_gently(const int fd_out, const char *buf, size_t size)
+static int packet_write_gently(const int fd_out, const char *buf, size_t size)
{
static char packet_write_buffer[LARGE_PACKET_MAX];
--
2.10.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pkt-line: mark a file-local symbol static
2016-09-14 13:31 [PATCH] pkt-line: mark a file-local symbol static Ramsay Jones
@ 2016-09-15 16:46 ` Lars Schneider
0 siblings, 0 replies; 2+ messages in thread
From: Lars Schneider @ 2016-09-15 16:46 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, GIT Mailing-list
> On 14 Sep 2016, at 14:31, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
>
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Lars,
>
> If you need to re-roll your 'ls/filter-process' branch, could you
> please squash this into the relevant patch; commit 2afd9b22
> ("pkt-line: add packet_write_gently()", 08-09-2016).
>
> [...]
> -int packet_write_gently(const int fd_out, const char *buf, size_t size)
> +static int packet_write_gently(const int fd_out, const char *buf, size_t size)
> {
> static char packet_write_buffer[LARGE_PACKET_MAX];
Done!
Thank you,
Lars
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-15 19:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 13:31 [PATCH] pkt-line: mark a file-local symbol static Ramsay Jones
2016-09-15 16:46 ` Lars Schneider
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox