Git development
 help / color / mirror / Atom feed
From: "Kyle J. McKay" <mackyle@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: maintainer question: config http.<url>.* patch administrivia
Date: Wed, 17 Jul 2013 08:02:33 -0700	[thread overview]
Message-ID: <68EA6AFC-D90D-4704-AF1A-92AF15617E23@gmail.com> (raw)

I have pondered these items:

On Jul 12, 2013, at 11:48, Junio C Hamano wrote:
> Perhaps we should fix it as a preparatory patch (1/2) before the
> main "feature addition" patch.


On Jul 12, 2013, at 11:52, Junio C Hamano wrote:
> Subject: [PATCH] http.c: fix parsing of  
> http.sslCertPasswordProtected variable

On Jul 14, 2013, at 21:02, Junio C Hamano wrote:
> Assuming that Aaron and Peff's enhancement will not be a backward
> incompatible update, my preference is to take the posted matching
> semantics as-is (you may have some other changes that does not
> change the "strictly textual match" semantics).

And in response I have previously sent out a combined v5 patch that has:

0001: your preparatory http.sslCertPasswordProtected patch
0002: logically related GIT_SSL_CERT_PASSWORD_PROTECTED patch
0003: textual matching http.<url>.* patch
0004: url normalization matching http.<url>.*
0005: test for url normalization function

However, upon further consideration (I noticed that the preparatory  
patch and v4 of the textual matching patch made their way into pu),  
perhaps it would be more convenient for you if I re-released the  
following patch series:


[PATCH v5]: config: support http.<url>.* settings - (1) textual matching

* contains 0001 the same preparatory http.sslCertPasswordProtected
* contains 0002 the same v5 textual matching http.<url>.* patch


[PATCH v2]: config: support http.<url>.* settings - (2) url  
normalization

* contains 0001 url normalization matching with feedback updates
* contains 0002 url normalization test


[PATCH v1]: config: support http.<url>.* settings - (3) any user  
matching

* contains 0001 a new patch that extends (2) to include any user  
matching


And drop the GIT_SSL_CERT_PASSWORD_PROTECTED patch as while it's  
logically related to the http.sslCertPasswordProtected patch it's not  
logistically related since independent areas of the file are touched  
and it could be successfully applied before or after the other  
patches.  It can go together with any forthcoming enable-only fix for  
GIT_SSL_CERT_PASSWORD_PROTECTED and other such environment variables  
or just be dropped entirely.

I do not, however, wish to create any additional maintainer work, so  
wanted to check with you before sending out any of the reissues.

             reply	other threads:[~2013-07-17 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 15:02 Kyle J. McKay [this message]
2013-07-17 17:35 ` maintainer question: config http.<url>.* patch administrivia Junio C Hamano
2013-07-17 18:15   ` Kyle J. McKay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68EA6AFC-D90D-4704-AF1A-92AF15617E23@gmail.com \
    --to=mackyle@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox