From: "Kyle J. McKay" <mackyle@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: maintainer question: config http.<url>.* patch administrivia
Date: Wed, 17 Jul 2013 11:15:53 -0700 [thread overview]
Message-ID: <CCADBC71-B5F4-4D69-B359-AF45F15F2816@gmail.com> (raw)
In-Reply-To: <7v7ggp6qdf.fsf@alter.siamese.dyndns.org>
On Jul 17, 2013, at 10:35, Junio C Hamano wrote:
> "Kyle J. McKay" <mackyle@gmail.com> writes:
>
>> perhaps it would be more convenient for you if I re-released the
>> following patch series:
>
> If "These build on top of each other in this order", then it is
> easier for me to manage if they were in a single series.
Yup. They build on one another so each requires the previous. Will
keep them in a single series.
> If f1ff763a (http.c: fix parsing of http.sslCertPasswordProtected
> variable, 2013-07-12) is already solid and need no further tweaking,
> it would be wise not to include the patch in any of your reroll in
> any case. Instead, just build your series on top of that commit,
> and make it clear that the series is meant to apply on top of that
> commit in the cover letter [0/n] of the series, or after "---" line
> of the first patch [1/n] in the series.
Got it. Will do. f1ff763a looks solid to me:
Reviewed-by: Kyle J. McKay <mackyle@gmail.com>
And earlier:
On Jul 12, 2013, at 12:05, Jonathan Nieder wrote:
> Subject: Re: [PATCH] http.c: fix parsing of
> http.sslCertPasswordProtected variable
>
> this change looks good.
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
so I will drop it from any future series and just refer to it in the
cover letter as you suggest.
> As to allowing GIT_SSL_CERT_PASSWORD_PROTECTED=no, I agree that it
> does not belong to the http.*.<var> configuration series
Agreed. Will not include it in any future http.*.<var> series.
> If the other patches have any textual dependency, you can
> make it [1/n] of your series and we can treat it just like f1ff763a,
> that is, make sure it is solid regardless of the rest of the series,
> and make it advance before the remainder of the series, so that we
> can still replace http.*.<var> implementation on top of these two
> freely.
Got it. Will do that and keep it in a single series.
Thanks for the direction,
Kyle
prev parent reply other threads:[~2013-07-17 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 15:02 maintainer question: config http.<url>.* patch administrivia Kyle J. McKay
2013-07-17 17:35 ` Junio C Hamano
2013-07-17 18:15 ` Kyle J. McKay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CCADBC71-B5F4-4D69-B359-AF45F15F2816@gmail.com \
--to=mackyle@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox