From: Derrick Stolee <stolee@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <ps@pks.im>,
Ezekiel Newren <ezekielnewren@gmail.com>
Subject: Re: [PATCH v2 0/4] Enable Rust by default
Date: Fri, 10 Apr 2026 11:06:00 -0400 [thread overview]
Message-ID: <6eb384e6-7134-4f99-a6b6-e8608ccc9dca@gmail.com> (raw)
In-Reply-To: <20260409224434.1861422-1-sandals@crustytoothpaste.net>
On 4/9/2026 6:44 PM, brian m. carlson wrote:
> Our breaking changes document said that we would enable Rust support by
> default in Git 2.53, while still leaving the ability for it to be
> disabled. Unfortunately, we forgot to do that and my time machine is
> broken right now, so this series sets it up for Git 2.54.
The discussion about how to handle the 2.54.0/2.55.0 release details
seems to have concluded, so I went to review the series more carefully.
If we take Junio's patch instead of this series's patch 1, then patches
2-4 look good.
I had some initial confusion about patch 4's references to Rust being
"optional" and it helps to know that there is a mechanism to _opt out_
of Rust builds. So the real conclusion is that we're moving from an
opt-in system to an opt-out system. This is a nice way to make progress
relatively safely.
Thanks,
-Stolee
prev parent reply other threads:[~2026-04-10 15:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:44 [PATCH v2 0/4] Enable Rust by default brian m. carlson
2026-04-09 22:44 ` [PATCH v2 1/4] docs: update version with default Rust support brian m. carlson
2026-04-09 22:44 ` [PATCH v2 2/4] ci: install cargo on Alpine brian m. carlson
2026-04-09 22:44 ` [PATCH v2 3/4] Linux: link against libdl brian m. carlson
2026-04-09 22:44 ` [PATCH v2 4/4] Enable Rust by default brian m. carlson
2026-04-10 13:02 ` [PATCH v2 0/4] " Derrick Stolee
2026-04-10 14:52 ` Re*: " Junio C Hamano
2026-04-10 15:02 ` Derrick Stolee
2026-04-10 20:04 ` brian m. carlson
2026-04-10 20:23 ` Junio C Hamano
2026-04-10 22:35 ` brian m. carlson
2026-04-10 21:13 ` Junio C Hamano
2026-04-10 21:48 ` brian m. carlson
2026-04-10 15:06 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb384e6-7134-4f99-a6b6-e8608ccc9dca@gmail.com \
--to=stolee@gmail.com \
--cc=ezekielnewren@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox