Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	 git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>,
	 Ezekiel Newren <ezekielnewren@gmail.com>
Subject: Re*: [PATCH v2 0/4] Enable Rust by default
Date: Fri, 10 Apr 2026 07:52:50 -0700	[thread overview]
Message-ID: <xmqqa4varhod.fsf_-_@gitster.g> (raw)
In-Reply-To: <4efc4133-3726-4b9d-8f06-03c07d48af99@gmail.com> (Derrick Stolee's message of "Fri, 10 Apr 2026 09:02:13 -0400")

Derrick Stolee <stolee@gmail.com> writes:

> On 4/9/2026 6:44 PM, brian m. carlson wrote:
>> Our breaking changes document said that we would enable Rust support by
>> default in Git 2.53, while still leaving the ability for it to be
>> disabled.  Unfortunately, we forgot to do that and my time machine is
>> broken right now, so this series sets it up for Git 2.54.
>
> I'm glad you're remembering to help us follow through on this promise.
>
> However, I'm worried that we shouldn't do this change during the rc
> window for 2.54.0. Perhaps we could get a small patch that updates the
> docs to say "we really mean 2.55.0" that lands in the 2.54.0 release,
> and then we merge the requirements for the build in the first batch
> after the release.
>
> This would give us a full release cycle to simmer with the requirement
> instead of slipping it in for the last rc.

Yes, let's do that.

I thought that leaving a bit of wiggle room like this:

  2. In Git 2.55 (or later, if the codebase and the world is not yet ready by then),
     both build systems will default-enable support for Rust.

might not be a bad idea, but during the -rc period, simpler the better.

----- >8 -----
Subject: rust: we are way beyond 2.53

Earlier we timelined that we'd tune our build procedures to build
with Rust by default in Git 2.53, but we are already in prerelease
freeze for 2.54 now.  Update the BreakingChanges document to delay
it until Git 2.55 (slated for the end of June 2026).

Noticed-by: brian m. carlson <sandals@crustytoothpaste.net>
Helped-by: Derrick Stolee <stolee@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/BreakingChanges.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git c/Documentation/BreakingChanges.adoc w/Documentation/BreakingChanges.adoc
index f814450d2f..af59c43f42 100644
--- c/Documentation/BreakingChanges.adoc
+++ w/Documentation/BreakingChanges.adoc
@@ -190,7 +190,7 @@ milestones for the introduction of Rust:
 1. Initially, with Git 2.52, support for Rust will be auto-detected by Meson and
    disabled in our Makefile so that the project can sort out the initial
    infrastructure.
-2. In Git 2.53, both build systems will default-enable support for Rust.
+2. In Git 2.55, both build systems will default-enable support for Rust.
    Consequently, builds will break by default if Rust is not available on the
    build host. The use of Rust can still be explicitly disabled via build
    flags.

  reply	other threads:[~2026-04-10 14:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 22:44 [PATCH v2 0/4] Enable Rust by default brian m. carlson
2026-04-09 22:44 ` [PATCH v2 1/4] docs: update version with default Rust support brian m. carlson
2026-04-09 22:44 ` [PATCH v2 2/4] ci: install cargo on Alpine brian m. carlson
2026-04-09 22:44 ` [PATCH v2 3/4] Linux: link against libdl brian m. carlson
2026-04-09 22:44 ` [PATCH v2 4/4] Enable Rust by default brian m. carlson
2026-04-10 13:02 ` [PATCH v2 0/4] " Derrick Stolee
2026-04-10 14:52   ` Junio C Hamano [this message]
2026-04-10 15:02     ` Re*: " Derrick Stolee
2026-04-10 20:04   ` brian m. carlson
2026-04-10 20:23     ` Junio C Hamano
2026-04-10 22:35       ` brian m. carlson
2026-04-10 21:13     ` Junio C Hamano
2026-04-10 21:48       ` brian m. carlson
2026-04-10 15:06 ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa4varhod.fsf_-_@gitster.g \
    --to=gitster@pobox.com \
    --cc=ezekielnewren@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox