* [PATCH] string-list: remove print_string_list, since it is not used anymore.
@ 2010-01-11 21:29 Thiago Farina
2010-01-11 21:52 ` Johannes Schindelin
0 siblings, 1 reply; 6+ messages in thread
From: Thiago Farina @ 2010-01-11 21:29 UTC (permalink / raw)
To: git
Signed-off-by: Thiago Farina <tfransosi@gmail.com>
---
string-list.c | 10 ----------
string-list.h | 1 -
2 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/string-list.c b/string-list.c
index 1ac536e..e929745 100644
--- a/string-list.c
+++ b/string-list.c
@@ -138,16 +138,6 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
list->nr = list->alloc = 0;
}
-
-void print_string_list(const char *text, const struct string_list *p)
-{
- int i;
- if ( text )
- printf("%s\n", text);
- for (i = 0; i < p->nr; i++)
- printf("%s:%p\n", p->items[i].string, p->items[i].util);
-}
-
struct string_list_item *string_list_append(const char *string, struct string_list *list)
{
ALLOC_GROW(list->items, list->nr + 1, list->alloc);
diff --git a/string-list.h b/string-list.h
index 6569cf6..8598257 100644
--- a/string-list.h
+++ b/string-list.h
@@ -12,7 +12,6 @@ struct string_list
unsigned int strdup_strings:1;
};
-void print_string_list(const char *text, const struct string_list *p);
void string_list_clear(struct string_list *list, int free_util);
/* Use this function to call a custom clear function on each util pointer */
--
1.6.6.103.g699d2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.
2010-01-11 21:29 [PATCH] string-list: remove print_string_list, since it is not used anymore Thiago Farina
@ 2010-01-11 21:52 ` Johannes Schindelin
2010-01-11 22:14 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Johannes Schindelin @ 2010-01-11 21:52 UTC (permalink / raw)
To: Thiago Farina; +Cc: git
Hi.
On Mon, 11 Jan 2010, Thiago Farina wrote:
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
It was never used, except for debugging. Does it hurt you really all that
much?
Ciao,
Dscho
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.
2010-01-11 21:52 ` Johannes Schindelin
@ 2010-01-11 22:14 ` Junio C Hamano
2010-01-11 22:23 ` Nicolas Pitre
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2010-01-11 22:14 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: Thiago Farina, git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Mon, 11 Jan 2010, Thiago Farina wrote:
>
>> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
>> ---
>
> It was never used, except for debugging. Does it hurt you really all that
> much?
Exactly my feeling.
I think I discarded at least two other patches sent to me to remove this
"unused" (but obviously meant for debugging) function in the past. I
guess we'll keep the function this time, too.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.
2010-01-11 22:14 ` Junio C Hamano
@ 2010-01-11 22:23 ` Nicolas Pitre
2010-01-11 22:34 ` Thiago Farina
0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Pitre @ 2010-01-11 22:23 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Johannes Schindelin, Thiago Farina, git
On Mon, 11 Jan 2010, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Mon, 11 Jan 2010, Thiago Farina wrote:
> >
> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> >> ---
> >
> > It was never used, except for debugging. Does it hurt you really all that
> > much?
>
> Exactly my feeling.
>
> I think I discarded at least two other patches sent to me to remove this
> "unused" (but obviously meant for debugging) function in the past. I
> guess we'll keep the function this time, too.
If so many people are so inclined to discard it, then maybe a little
comment could be added to explain its existance?
Nicolas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.
2010-01-11 22:23 ` Nicolas Pitre
@ 2010-01-11 22:34 ` Thiago Farina
2010-01-11 22:51 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Thiago Farina @ 2010-01-11 22:34 UTC (permalink / raw)
To: Nicolas Pitre; +Cc: Junio C Hamano, Johannes Schindelin, git
On Mon, Jan 11, 2010 at 8:23 PM, Nicolas Pitre <nico@fluxnic.net> wrote:
> On Mon, 11 Jan 2010, Junio C Hamano wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > On Mon, 11 Jan 2010, Thiago Farina wrote:
>> >
>> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
>> >> ---
>> >
>> > It was never used, except for debugging. Does it hurt you really all that
>> > much?
>>
>> Exactly my feeling.
>>
>> I think I discarded at least two other patches sent to me to remove this
>> "unused" (but obviously meant for debugging) function in the past. I
>> guess we'll keep the function this time, too.
>
> If so many people are so inclined to discard it, then maybe a little
> comment could be added to explain its existance?
>
I can add the comment if Junio is ok with it. Something like this:
"This functions is for debugging purpose only. Please, do NOT remove
it."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] string-list: remove print_string_list, since it is not used anymore.
2010-01-11 22:34 ` Thiago Farina
@ 2010-01-11 22:51 ` Junio C Hamano
0 siblings, 0 replies; 6+ messages in thread
From: Junio C Hamano @ 2010-01-11 22:51 UTC (permalink / raw)
To: Thiago Farina; +Cc: Nicolas Pitre, Junio C Hamano, Johannes Schindelin, git
Thiago Farina <tfransosi@gmail.com> writes:
> I can add the comment if Junio is ok with it. Something like this:
> "This functions is for debugging purpose only. Please, do NOT remove
> it."
Something like this should suffice, as I think "Please blah" is just
superfluous.
I don't know if I like "#ifdef DEBUG" better, though. It will still let
you say "call print_string_list(...)" in your debugger session, and people
wouldn't muck with it even if there is no caller.
diff --git a/string-list.c b/string-list.c
index 1ac536e..793e619 100644
--- a/string-list.c
+++ b/string-list.c
@@ -139,6 +139,7 @@ void string_list_clear_func(struct string_list *list, string_list_clear_func_t c
}
+#ifndef NDEBUG
void print_string_list(const char *text, const struct string_list *p)
{
int i;
@@ -147,6 +148,7 @@ void print_string_list(const char *text, const struct string_list *p)
for (i = 0; i < p->nr; i++)
printf("%s:%p\n", p->items[i].string, p->items[i].util);
}
+#endif
struct string_list_item *string_list_append(const char *string, struct string_list *list)
{
diff --git a/string-list.h b/string-list.h
index 6569cf6..8598257 100644
--- a/string-list.h
+++ b/string-list.h
@@ -12,7 +12,6 @@ struct string_list
unsigned int strdup_strings:1;
};
-void print_string_list(const char *text, const struct string_list *p);
void string_list_clear(struct string_list *list, int free_util);
/* Use this function to call a custom clear function on each util pointer */
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-01-11 22:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-11 21:29 [PATCH] string-list: remove print_string_list, since it is not used anymore Thiago Farina
2010-01-11 21:52 ` Johannes Schindelin
2010-01-11 22:14 ` Junio C Hamano
2010-01-11 22:23 ` Nicolas Pitre
2010-01-11 22:34 ` Thiago Farina
2010-01-11 22:51 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox