From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: [PATCH] Fix update-cache --remove fix.
Date: Sun, 17 Apr 2005 01:58:42 -0700 [thread overview]
Message-ID: <7v3btp230d.fsf@assigned-by-dhcp.cox.net> (raw)
There is a boundary case bug in the update-cache --remove fix I
sent earlier, which results in a segfault when trying to remove
a nonexistent name that sorts later than anything in the
dircache. Here is a fix.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
read-cache.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
read-cache.c: 60b8efb3201fbf0a67bef48775bd1c9a1ccae2ff
--- read-cache.c
+++ read-cache.c 2005-04-17 01:50:00.000000000 -0700
@@ -371,7 +371,8 @@
int pos = cache_name_pos(path, strlen(path));
if (pos < 0)
pos = -pos-1;
- while (! strcmp(active_cache[pos]->name, path))
+ while ((pos < active_nr) &&
+ ! strcmp(active_cache[pos]->name, path))
remove_entry_at(pos);
return 0;
}
reply other threads:[~2005-04-17 8:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3btp230d.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox