* [PATCH] Fix update-cache --remove fix.
@ 2005-04-17 8:58 Junio C Hamano
0 siblings, 0 replies; only message in thread
From: Junio C Hamano @ 2005-04-17 8:58 UTC (permalink / raw)
To: Linus Torvalds; +Cc: git
There is a boundary case bug in the update-cache --remove fix I
sent earlier, which results in a segfault when trying to remove
a nonexistent name that sorts later than anything in the
dircache. Here is a fix.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
read-cache.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
read-cache.c: 60b8efb3201fbf0a67bef48775bd1c9a1ccae2ff
--- read-cache.c
+++ read-cache.c 2005-04-17 01:50:00.000000000 -0700
@@ -371,7 +371,8 @@
int pos = cache_name_pos(path, strlen(path));
if (pos < 0)
pos = -pos-1;
- while (! strcmp(active_cache[pos]->name, path))
+ while ((pos < active_nr) &&
+ ! strcmp(active_cache[pos]->name, path))
remove_entry_at(pos);
return 0;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-17 8:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-17 8:58 [PATCH] Fix update-cache --remove fix Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox