From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Tay Ray Chuan <rctay89@gmail.com>
Subject: Re: [PATCH] t5540-http-push.sh: avoid non-portable grep -P
Date: Thu, 26 Feb 2009 15:29:39 -0800 [thread overview]
Message-ID: <7v4oygrd3w.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <76718490902261440p4c9981fbncbdd58ad12e38349@mail.gmail.com> (Jay Soffian's message of "Thu, 26 Feb 2009 17:40:25 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> On Thu, Feb 26, 2009 at 5:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I don't mind Perl as we already depend on it; the looseness of the regexp
>> stil bothers me somewhat, though...
>
> I think you're letting the perfect be the enemy of the good. The point
> of the test is merely to check for the SHA-1 has suffix in PUT/MOVE
> operations. Any of my suggestions so far are better than what is there
> now. Why so much fuss?
>
> I'll send one more iteration, and if that's not good enough, I give up.
>
> j.
Heh, at least with /a-z/a-f/, I think it is usable.
Or is there a reason I am missing that we want to allow g-z there?
next prev parent reply other threads:[~2009-02-26 23:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 19:49 [PATCH] t5540-http-push.sh: avoid non-portable grep -P Jay Soffian
2009-02-26 20:30 ` Junio C Hamano
2009-02-26 20:43 ` Jay Soffian
2009-02-26 20:46 ` Jay Soffian
2009-02-26 21:48 ` Junio C Hamano
2009-02-26 22:19 ` Jay Soffian
2009-02-26 22:37 ` Junio C Hamano
2009-02-26 22:40 ` Jay Soffian
2009-02-26 22:45 ` [PATCH v3] " Jay Soffian
2009-02-26 23:29 ` Junio C Hamano [this message]
2009-02-26 23:40 ` [PATCH] " Jay Soffian
2009-02-26 23:44 ` [PATCH v4] " Jay Soffian
2009-02-26 23:51 ` [PATCH] " Brandon Casey
2009-02-26 23:58 ` Johannes Schindelin
2009-02-27 0:12 ` Brandon Casey
2009-02-27 0:24 ` Junio C Hamano
2009-02-26 21:41 ` [PATCH v2] " Jay Soffian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v4oygrd3w.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox