From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org, "Andreas Färber" <andreas.faerber@web.de>
Subject: Re: [PATCH 1/2] compat: introduce stat_to_kilobytes
Date: Tue, 19 Aug 2008 00:31:42 -0700 [thread overview]
Message-ID: <7v7iadh34x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vbpzqm50b.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 18 Aug 2008 13:40:04 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Sixt <johannes.sixt@telecom.at> writes:
> ...
>> But notice that we now underestimated the size of loose objects more than
>> we did previously because we now round down individual sizes; previously
>> we rounded down only the total size.
>
> Ah, you are right.
>
> Perhaps we should fix this by making the helper stat_to_on_disk_bytes(),
> so that on platform with st_blocks counted in 512-byte blocks we multiply
> it by 512?
I've done this myself and will queue the result.
next prev parent reply other threads:[~2008-08-19 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 8:59 [PATCH 4/6] Don't use struct stat's st_blocks member on Haiku Andreas Färber
2008-08-17 9:28 ` Jakub Narebski
2008-08-17 9:47 ` [PATCH] compat: introduce stat_to_kilobytes Junio C Hamano
2008-08-17 17:27 ` Andreas Färber
2008-08-18 19:57 ` [PATCH 1/2] " Johannes Sixt
2008-08-18 20:01 ` [PATCH 2/2] Revert "Windows: Use a customized struct stat that also has the st_blocks member." Johannes Sixt
2008-08-18 20:44 ` Junio C Hamano
2008-08-18 20:40 ` [PATCH 1/2] compat: introduce stat_to_kilobytes Junio C Hamano
2008-08-19 7:31 ` Junio C Hamano [this message]
2008-08-19 8:39 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7iadh34x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=andreas.faerber@web.de \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox