From: Jakub Narebski <jnareb@gmail.com>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 4/6] Don't use struct stat's st_blocks member on Haiku
Date: Sun, 17 Aug 2008 02:28:59 -0700 (PDT) [thread overview]
Message-ID: <m31w0ot2ga.fsf@localhost.localdomain> (raw)
In-Reply-To: <273481A4-0BB2-4A58-83AD-604B425DE824@web.de>
Andreas Färber <andreas.faerber@web.de> writes:
> Signed-off-by: Andreas Faerber <andreas.faerber@web.de>
> Signed-off-by: Ingo Weinhold <ingo_weinhold@gmx.de>
> ---
> BeOS didn't have that field, so neither has Haiku currently.
> It is part of the optional XSI POSIX feature.
>
> Makefile | 4 ++++
> builtin-count-objects.c | 4 ++++
> configure.ac | 8 ++++++++
> 3 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 5dba2c7..a4d73fc 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -730,6 +730,7 @@ ifeq ($(uname_S),HP-UX)
> endif
> ifeq ($(uname_S),Haiku)
> NO_IPV6 = YesPlease
> + NO_ST_BLOCKS_IN_STAT = YesPlease
> EXTLIBS += -lnetwork
> endif
> ifneq (,$(findstring MINGW,$(uname_S)))
> @@ -867,6 +868,9 @@ endif
> ifdef NO_D_INO_IN_DIRENT
> BASIC_CFLAGS += -DNO_D_INO_IN_DIRENT
> endif
> +ifdef NO_ST_BLOCKS_IN_STAT
> + BASIC_CFLAGS += -DNO_ST_BLOCKS_IN_STAT
> +endif
> ifdef NO_C99_FORMAT
> BASIC_CFLAGS += -DNO_C99_FORMAT
> endif
It it is _new_ define you should have described it in comments in
Makefile header too.
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2008-08-17 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-17 8:59 [PATCH 4/6] Don't use struct stat's st_blocks member on Haiku Andreas Färber
2008-08-17 9:28 ` Jakub Narebski [this message]
2008-08-17 9:47 ` [PATCH] compat: introduce stat_to_kilobytes Junio C Hamano
2008-08-17 17:27 ` Andreas Färber
2008-08-18 19:57 ` [PATCH 1/2] " Johannes Sixt
2008-08-18 20:01 ` [PATCH 2/2] Revert "Windows: Use a customized struct stat that also has the st_blocks member." Johannes Sixt
2008-08-18 20:44 ` Junio C Hamano
2008-08-18 20:40 ` [PATCH 1/2] compat: introduce stat_to_kilobytes Junio C Hamano
2008-08-19 7:31 ` Junio C Hamano
2008-08-19 8:39 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31w0ot2ga.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=andreas.faerber@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox