From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: [PATCH] Really honor umask when creating files
Date: Sun, 17 Apr 2005 01:15:48 -0700 [thread overview]
Message-ID: <7v7jj124zv.fsf@assigned-by-dhcp.cox.net> (raw)
The stated plan was to create new files with either 0666 or 0777
and let the system take care of applying umask(). Running
fchmod afterwards defeats this plan, so drop it.
You still need to spell your octals with prefix in addition to
this patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
checkout-cache.c | 2 --
1 files changed, 2 deletions(-)
checkout-cache.c: a87022a97c4604ef42ae6c31d641dc749a076ca3
--- checkout-cache.c
+++ checkout-cache.c 2005-04-17 01:11:17.000000000 -0700
@@ -62,8 +62,6 @@
fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
}
}
- if (fd >= 0)
- fchmod(fd, mode);
return fd;
}
reply other threads:[~2005-04-17 8:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v7jj124zv.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox