* [PATCH] Really honor umask when creating files
@ 2005-04-17 8:15 Junio C Hamano
0 siblings, 0 replies; only message in thread
From: Junio C Hamano @ 2005-04-17 8:15 UTC (permalink / raw)
To: Linus Torvalds; +Cc: git
The stated plan was to create new files with either 0666 or 0777
and let the system take care of applying umask(). Running
fchmod afterwards defeats this plan, so drop it.
You still need to spell your octals with prefix in addition to
this patch.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
checkout-cache.c | 2 --
1 files changed, 2 deletions(-)
checkout-cache.c: a87022a97c4604ef42ae6c31d641dc749a076ca3
--- checkout-cache.c
+++ checkout-cache.c 2005-04-17 01:11:17.000000000 -0700
@@ -62,8 +62,6 @@
fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
}
}
- if (fd >= 0)
- fchmod(fd, mode);
return fd;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-17 8:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-17 8:15 [PATCH] Really honor umask when creating files Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox