git-send-email vs address syntax

git-send-email vs address syntax

[Brown, Len]

I recently used git-format-patch and git-send-email
to patch bomb 105 patches to linux-acpi@vger.kernel.org

But It appears that messages 37-45 and 96-104.
got dropped by the mail server because they
had a '.' in a destination address:

To:	linux-acpi@vger.kernel.org
Cc:	malattia@linux.it <malattia@linux.it>, Len Brown
<len.brown@intel.com>
Illegal-Object:	Syntax error in Cc: address found on vger.kernel.org:
	Cc:	malattia@linux.it<malattia@linux.it>
					 ^-missing end of address


Dave Miller says that this address would have been legal
if it were enclosed in quotes.

I don't know if the fix should be in the git-am script
which set the From: field, or in the git-format-patch
script which takes that field and makes it into
an e-mail message.

-Len

Re: git-send-email vs address syntax

[Junio C Hamano]

"Brown, Len" <len.brown@intel.com> writes:

> I don't know if the fix should be in the git-am script
> which set the From: field, or in the git-format-patch
> script which takes that field and makes it into
> an e-mail message.

The fix should be in send-email script, as COMMITTER_NAME and
AUTHOR_NAME are just simple strings without RFC2822 limitation
(such as necessity of quoting a ".").

As a matter of fact, recent enough send-email is supposed to
have a fix for this exact problem.  If your copy of send-email
does not have

	sub sanitize_address_rfc822 {

you might want to upgrade.  Both 1.5.2-rc1 and 1.5.1.3 have
this.

RE: git-send-email vs address syntax

[Brown, Len]

>As a matter of fact, recent enough send-email is supposed to
>have a fix for this exact problem.  If your copy of send-email
>does not have
>
>	sub sanitize_address_rfc822 {
>
>you might want to upgrade.  Both 1.5.2-rc1 and 1.5.1.3 have
>this.
>
>

Hmmm, the message has this tag at the bottom:
1.5.2.rc0.34.gda94

so I guess I didn't have the latest at the time.

thanks,
-Len