From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFD] Strange patch formats (aka tricks with unified diffs)..
Date: Sat, 14 Apr 2007 02:55:13 -0700 [thread overview]
Message-ID: <7vbqhrb7r2.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0704141051350.18846@racer.site> (Johannes Schindelin's message of "Sat, 14 Apr 2007 10:59:44 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Thu, 12 Apr 2007, Junio C Hamano wrote:
>
>> [...] the --color-words (whose implementation I happen to hate) [...]
>
> I know that we talked about it previously. And strictly, I think it is not
> the implementation that you hate, but the rules that were implemented.
>
> I'll have a look at what you wrote back then, and try to come up with some
> sensible alternatives, so you don't have to hate the code so much.
One sensible behaviour would be to show exactly the same output
lines as the regular output, but color-code only the words that
changed. E.g (the words are capitalized to illustrate instead
of colored here):
diff --git a/Documentation/git-cvsserver.txt b/Documentation/git-cvsserver.txt
index 6a5fcfd..535214c 100644
--- a/Documentation/git-cvsserver.txt
+++ b/Documentation/git-cvsserver.txt
@@ -125,7 +131,7 @@ By default it uses SQLite databases in the git directory, named
temporary files in the same directory as the database file on
write so it might not be enough to grant the users using
git-cvsserver write access to the database file without granting
-them ALSO write access to the directory.
+them write access to the directory, TOO.
You can configure the database backend with the following
configuration variables:
next prev parent reply other threads:[~2007-04-14 9:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 21:58 [RFD] Strange patch formats (aka tricks with unified diffs) Linus Torvalds
2007-04-12 23:02 ` Junio C Hamano
2007-04-13 5:38 ` Marco Costalba
2007-04-17 18:02 ` Marco Costalba
2007-04-13 5:43 ` Paul Mackerras
2007-04-13 6:07 ` Martin Langhoff
2007-04-13 6:35 ` Junio C Hamano
2007-04-13 7:01 ` Martin Langhoff
2007-04-14 8:59 ` Johannes Schindelin
2007-04-14 9:55 ` Junio C Hamano [this message]
2007-04-14 10:09 ` Jeff King
2007-04-13 15:16 ` Linus Torvalds
2007-04-18 1:44 ` Paul Mackerras
2007-04-18 4:02 ` Linus Torvalds
2007-04-13 8:10 ` Matthias Lederhofer
2007-04-13 15:00 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbqhrb7r2.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox