Re: [RFD] Strange patch formats (aka tricks with unified diffs)..

["Marco Costalba" <mcostalba@gmail.com>]

On 4/13/07, Marco Costalba <mcostalba@gmail.com> wrote:
> On 4/12/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> >
> > So I can see two ways to fix this:
> >  - bug Paul about alternate diff viewing capabilities in gitk. He's cc'd
> >    here. A way to make the "diff" pane show just the new one, the old one,
> >    or even both side-by-side with some mousy interface?
> >  - add some actual switch to git diff generation to hide the negative side
> >    of a unified diff, and add some way to just make gitk pass that switch
> >    in.
> >
> > I dunno. I realize that it's not just gitk - gitweb, qgit etc don't allow
> > the tricks *either*, but gitk was the one I just hit this with.
>
> Currently in qgit you can select a revision + a file and call an
> external diff viewer, as example Kompare (tweakable from
> 'Edir->settings->External diff viewer' menu) to view the diff
> side-by-side, or in any other way the viewer allows, for the selected
> file.
>
> I like also the idea to hide the negative side but I would rather
> prefer a togglable command/button instead of a command line argument
> or a setting, so to allow easy and quick hide/unhide on the same
> patch.
>
> I will work on it..... ;-)
>

I have pushed a patch with support for toggling view of the negative
side of an unified diff (right most 'filter' button in patch viewer
tab or CTRL+H shortcut).

In case someone is interested repo is, as usual,

                git://git.kernel.org/pub/scm/qgit/qgit.git


  Marco

P.S: Another two useful shortcuts are the hide/unhide of revision
description header ('h' key or from 'View' menu) and hide/unhide of
secondary panes ('s' key or from 'View' menu) they work in all the
different tabs.