From: Junio C Hamano <junkio@cox.net>
To: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-mv: fully detect 'directory moved into itself'
Date: Mon, 28 Nov 2005 01:24:10 -0800 [thread overview]
Message-ID: <7vbr05xgzp.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200511281015.15188.Josef.Weidendorfer@gmx.de> (Josef Weidendorfer's message of "Mon, 28 Nov 2005 10:15:15 +0100")
Josef Weidendorfer <Josef.Weidendorfer@gmx.de> writes:
> This is a corrected version.
>
> On Monday 28 November 2005 07:54, Matthias Urlichs wrote:
>> Hi, Josef Weidendorfer wrote:
>>
>> > + if (($bad eq "") && ($dst =~ /^$src\//)) {
>>
>> That should be
>>
>> > + if (($bad eq "") && ($dst =~ /^\Q$src\E\//)) {
>>
>> otherwise you will mistakenly match "foo-bar" with "foo.bar".
>
> Ah, thanks.
> You never end learning.
Why not use $safesrc you already have for this exact purpose?
prev parent reply other threads:[~2005-11-28 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-27 21:06 git-mv: fully detect 'directory moved into itself' Josef Weidendorfer
2005-11-28 6:54 ` Matthias Urlichs
2005-11-28 9:15 ` [PATCH] " Josef Weidendorfer
2005-11-28 9:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vbr05xgzp.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Josef.Weidendorfer@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox