Git development
 help / color / mirror / Atom feed
From: Matthias Urlichs <smurf@smurf.noris.de>
To: git@vger.kernel.org
Subject: Re: git-mv: fully detect 'directory moved into itself'
Date: Mon, 28 Nov 2005 07:54:34 +0100	[thread overview]
Message-ID: <pan.2005.11.28.06.54.32.809941@smurf.noris.de> (raw)
In-Reply-To: 200511272206.43113.Josef.Weidendorfer@gmx.de

Hi, Josef Weidendorfer wrote:

> +    if (($bad eq "") && ($dst =~ /^$src\//)) {

That should be

> +    if (($bad eq "") && ($dst =~ /^\Q$src\E\//)) {

otherwise you will mistakenly match "foo-bar" with "foo.bar".

-- 
Matthias Urlichs   |   {M:U} IT Design @ m-u-it.de   |  smurf@smurf.noris.de
Disclaimer: The quote was selected randomly. Really. | http://smurf.noris.de
 - -
If people drank ink instead of Schlitz, they'd be better off.
		-- Edward E. Hippensteel

[What brand of ink?  Ed.]

  reply	other threads:[~2005-11-28  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-27 21:06 git-mv: fully detect 'directory moved into itself' Josef Weidendorfer
2005-11-28  6:54 ` Matthias Urlichs [this message]
2005-11-28  9:15   ` [PATCH] " Josef Weidendorfer
2005-11-28  9:24     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2005.11.28.06.54.32.809941@smurf.noris.de \
    --to=smurf@smurf.noris.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox