bug in make install

bug in make install

[Marco Maggi]

Ciao,

upon installing GIT I  was bitten by the following behaviour
of  GNU   Bash  3.1  (from  the  Info   node  "Bourne  Shell
Builtins"):

| If a non-empty directory name from `CDPATH' is used, or if
| `-'  is the first  argument, and  the directory  change is
| successful,  the  absolute  pathname  of the  new  working
| directory is written to the standard output.

this is  triggered by setting "CDPATH=.",  that is including
"." in the list, when "templates/Makefile" does:

| (cd blt && $(TAR) cf - .) \
| (cd '$(DESTDIR_SQ)$(template_dir_SQ)' && umask 022 &&
$(TAR) xf -)

the absolute file name goes into the pipe and the "tar xf -"
fails  with  a "this  does  not  look  like a  tar  archive"
error. The problem is fixed by:

| (cd ./blt && $(TAR) cf - .)
|     ^^

Do not bother me asking why I put "." in CDPATH.

By the  way: the use of  tar annoys me a  little because the
installed files  are 0640, rather  than 0644, and I  have to
fix it while building my custom Slackware package. :/

-- 
Marco Maggi

"Now feel the funk blast!"
Rage Against the Machine - "Calm like a bomb"

Re: bug in make install

[Johannes Schindelin]

Hi,

On Wed, 2 Apr 2008, Marco Maggi wrote:

> Do not bother me asking why I put "." in CDPATH.

We will probably not bother.  But we mention that exporting CDPATH makes 
absolutely zero sense.

Ciao,
Dscho

Re: bug in make install

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Wed, 2 Apr 2008, Marco Maggi wrote:
>
>> Do not bother me asking why I put "." in CDPATH.
>
> We will probably not bother.  But we mention that exporting CDPATH makes 
> absolutely zero sense.

Often people who make this mistake do not know the difference between
setting it as a shell variable and exporting it to the environment, so a
comment to hint that there is a difference may be a helpful and friendly
thing to do.

Re: bug in make install

[Johannes Schindelin]

Hi,

On Wed, 2 Apr 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Wed, 2 Apr 2008, Marco Maggi wrote:
> >
> >> Do not bother me asking why I put "." in CDPATH.
> >
> > We will probably not bother.  But we mention that exporting CDPATH 
> > makes absolutely zero sense.
> 
> Often people who make this mistake do not know the difference between 
> setting it as a shell variable and exporting it to the environment, so a 
> comment to hint that there is a difference may be a helpful and friendly 
> thing to do.

Funny.  I did not even know about CDPATH until I joined the mailing list.  
So I assumed -- maybe mistakenly -- that everybody who wants to set 
CDPATH, especially to ".", knows what they are talking about.

Ciao,
Dscho