Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Move the pick_author code to git-sh-setup
Date: Sun, 24 Jun 2007 04:14:00 -0700	[thread overview]
Message-ID: <7vd4zlvc3r.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0706241118250.4059@racer.site> (Johannes Schindelin's message of "Sun, 24 Jun 2007 11:22:24 +0100 (BST)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> That is well possible. Quoting in shell is such a hassle, and I never seem 
> to get it right.
>
> Therefore I did a minimal test,...
>
> So I thought that it was okay.

Try the small test script in the message you are responding to.
It gives me:

        $ sh ./1.sh
        A= d e
        B= d  e

A quick rule of thumb is that the only place that you can get
away by not quoting is straight assignment to another variable,
like so:

	var='a  b c '
        another=$var	;# another="$var" is fine but unnecessary.

Similarly for

	another=$(some command)

which is Ok not to dquote.

  reply	other threads:[~2007-06-24 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-23 23:01 [PATCH 1/2] Move the pick_author code to git-sh-setup Johannes Schindelin
2007-06-24  6:39 ` Junio C Hamano
2007-06-24  7:09   ` Junio C Hamano
2007-06-24 10:22   ` Johannes Schindelin
2007-06-24 11:14     ` Junio C Hamano [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-06-23 23:01 [PATCH 2/2] Teach rebase an interactive mode Johannes Schindelin
2007-06-24  8:15 ` Junio C Hamano
2007-06-24 11:09   ` Johannes Schindelin
2007-06-25  0:04     ` [PATCH 1/2] Move the pick_author code to git-sh-setup Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vd4zlvc3r.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox