From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] Move the pick_author code to git-sh-setup
Date: Sun, 24 Jun 2007 00:09:21 -0700 [thread overview]
Message-ID: <7vejk125i6.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <7v7ipt3lh6.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Sat, 23 Jun 2007 23:39:01 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
>> - set_author_env=`git show -s --pretty=raw --encoding="$encoding" "$use_commit" |
>> - LANG=C LC_ALL=C sed -ne "$pick_author_script"`
>> - eval "$set_author_env"
>> ...
>> + eval $(get_author_ident_from_commit "$use_commit")
>
> Are you sure about this part of the change? I suspect that you
> are losing IFS by not dq'ing the argument you give to the eval.
>
> ...
If you care about your data in your variable and do not want
word-splitting at $IFS to happen, you should always dq your
variable. A quick rule of thumb is that the only place that you
can get away by not quoting is straight assignment to another
variable, like so:
var='a b c '
another=$var ;# another="$var" is fine but unnecessary.
next prev parent reply other threads:[~2007-06-24 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 23:01 [PATCH 1/2] Move the pick_author code to git-sh-setup Johannes Schindelin
2007-06-24 6:39 ` Junio C Hamano
2007-06-24 7:09 ` Junio C Hamano [this message]
2007-06-24 10:22 ` Johannes Schindelin
2007-06-24 11:14 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2007-06-23 23:01 [PATCH 2/2] Teach rebase an interactive mode Johannes Schindelin
2007-06-24 8:15 ` Junio C Hamano
2007-06-24 11:09 ` Johannes Schindelin
2007-06-25 0:04 ` [PATCH 1/2] Move the pick_author code to git-sh-setup Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vejk125i6.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox