* [PATCH] quote.c: silence compiler warnings from EMIT macro
@ 2006-06-28 5:59 Jeff King
2006-06-28 10:01 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Jeff King @ 2006-06-28 5:59 UTC (permalink / raw)
To: junkio; +Cc: git
Signed-off-by: Jeff King <peff@peff.net>
---
This allows compiling with gcc -Wall -Werror, which makes finding useful
warnings easier. I also think the 'if' is easier to read than the
short-circuit.
quote.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/quote.c b/quote.c
index dcc2326..1910d00 100644
--- a/quote.c
+++ b/quote.c
@@ -13,7 +13,7 @@ #include "quote.h"
* a!b ==> a'\!'b ==> 'a'\!'b'
*/
#undef EMIT
-#define EMIT(x) ( (++len < n) && (*bp++ = (x)) )
+#define EMIT(x) do { if (++len < n) *bp++ = (x); } while(0)
static inline int need_bs_quote(char c)
{
--
1.4.1.rc1.g29f4a-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-28 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-28 5:59 [PATCH] quote.c: silence compiler warnings from EMIT macro Jeff King
2006-06-28 10:01 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox