From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Miklos Vajna" <vmiklos@frugalware.org>,
"Ilari Liusvaara" <ilari.liusvaara@elisanet.fi>,
git@vger.kernel.org
Subject: Re: [PATCH] Fix archive format with -- on the command line
Date: Wed, 30 Dec 2009 00:11:52 -0800 [thread overview]
Message-ID: <7vhbr8519z.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091230121309.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Wed\, 30 Dec 2009 12\:13\:09 +0900")
Nanako Shiraishi <nanako3@lavabit.com> writes:
> Junio, could you tell us what happened to this thread?
>
> "git archive HEAD non-existing-path" doesn't complain like "git
> add" does, and the patch is to fix it. No discussion.
It walks the tree twice, once for the checking and then another for doing
its real work. Doing that way obviously looks stupid and inefficient but
on the other hand it can fail before doing anything, which may be a big
plus. I couldn't decide the pros-and-cons at the moment.
Probably it is worth queuing the patch as is, and if there are motivated
people who want to, let them "optimize" it by rolling that check into the
main loop.
I dunno.
next prev parent reply other threads:[~2009-12-30 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 21:26 [BUG] git archive formats and dashdash Ilari Liusvaara
2009-12-10 22:05 ` Junio C Hamano
2009-12-10 22:22 ` Miklos Vajna
2009-12-10 22:42 ` Junio C Hamano
2009-12-10 23:27 ` [PATCH] Fix archive format with -- on the command line Junio C Hamano
2009-12-10 23:31 ` Junio C Hamano
2009-12-12 15:00 ` René Scharfe
2009-12-30 3:13 ` Nanako Shiraishi
2009-12-30 8:11 ` Junio C Hamano [this message]
2009-12-10 22:25 ` [BUG] git archive formats and dashdash Ilari Liusvaara
2009-12-10 22:20 ` [PATCH] builtin-archive: insert --format before double dash if necessary Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhbr8519z.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=nanako3@lavabit.com \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox