From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>, git@vger.kernel.org
Subject: Re: [BUG] git archive formats and dashdash
Date: Thu, 10 Dec 2009 14:42:10 -0800 [thread overview]
Message-ID: <7vws0u8n99.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091210222258.GQ4114@genesis.frugalware.org> (Miklos Vajna's message of "Thu\, 10 Dec 2009 23\:22\:58 +0100")
Miklos Vajna <vmiklos@frugalware.org> writes:
> On Thu, Dec 10, 2009 at 02:05:39PM -0800, Junio C Hamano <gitster@pobox.com> wrote:
>> Good catch. Is this a regression between 1.6.5 and the current code?
>
> Ah, you version is much shorter. :)
More importantly it would avoid running "archive path --format=zip".
That may be reordered by the current parse-options implementation, and
other command line parsers (e.g. "git diff HEAD path --stat") may accept
command line in such an order, but I somehow find it utterly wrong. We
should prepare ourselves for the (distant) day on which we start enforcing
"options then rev then paths" order from the command line.
next prev parent reply other threads:[~2009-12-10 22:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 21:26 [BUG] git archive formats and dashdash Ilari Liusvaara
2009-12-10 22:05 ` Junio C Hamano
2009-12-10 22:22 ` Miklos Vajna
2009-12-10 22:42 ` Junio C Hamano [this message]
2009-12-10 23:27 ` [PATCH] Fix archive format with -- on the command line Junio C Hamano
2009-12-10 23:31 ` Junio C Hamano
2009-12-12 15:00 ` René Scharfe
2009-12-30 3:13 ` Nanako Shiraishi
2009-12-30 8:11 ` Junio C Hamano
2009-12-10 22:25 ` [BUG] git archive formats and dashdash Ilari Liusvaara
2009-12-10 22:20 ` [PATCH] builtin-archive: insert --format before double dash if necessary Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vws0u8n99.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ilari.liusvaara@elisanet.fi \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox