* [PATCH] When generating manpages, delete outdated targets first.
@ 2007-08-01 23:48 David Kastrup
2007-08-02 0:53 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: David Kastrup @ 2007-08-01 23:48 UTC (permalink / raw)
To: git
This makes "make doc" work even if you made "sudo make doc" previously
by mistake. Apparently an oversight: the other targets did this already.
Signed-off-by: David Kastrup <dak@gnu.org>
---
Documentation/Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index 3bc5357..a186843 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -120,6 +120,7 @@ clean:
mv $@+ $@
%.1 %.5 %.7 : %.xml
+ $(RM) $@+ $@
xmlto -m callouts.xsl man $<
%.xml : %.txt
--
1.5.3.rc2.167.gbef44-dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] When generating manpages, delete outdated targets first.
2007-08-01 23:48 [PATCH] When generating manpages, delete outdated targets first David Kastrup
@ 2007-08-02 0:53 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2007-08-02 0:53 UTC (permalink / raw)
To: David Kastrup; +Cc: git
David Kastrup <dak@gnu.org> writes:
> This makes "make doc" work even if you made "sudo make doc" previously
> by mistake. Apparently an oversight: the other targets did this already.
>
> Signed-off-by: David Kastrup <dak@gnu.org>
> ---
> Documentation/Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/Makefile b/Documentation/Makefile
> index 3bc5357..a186843 100644
> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -120,6 +120,7 @@ clean:
> mv $@+ $@
>
> %.1 %.5 %.7 : %.xml
> + $(RM) $@+ $@
> xmlto -m callouts.xsl man $<
>
> %.xml : %.txt
I think "rm" makes sense; the call to xmlto in this Makefile has
been this way from day one, it seems ;-).
The build rule for this target does not use "generate to
temporary $@+ and after that is successful mv to the final $@"
pattern, so we do not have to remove $@+ in this target, though.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-02 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-01 23:48 [PATCH] When generating manpages, delete outdated targets first David Kastrup
2007-08-02 0:53 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox