Generating docu in 1.4.3.3.g01929

Generating docu in 1.4.3.3.g01929

[Horst H. von Brand]

I'm getting lots of these after today's pull:

asciidoc -b docbook -d manpage -f asciidoc.conf git-daemon.txt
xmlto -m callouts.xsl man git-daemon.xml
error : unterminated entity reference                
error : unterminated entity reference                
error : unterminated entity reference             ...
error : unterminated entity reference                
error : unterminated entity reference                
Writing git-daemon.1 for refentry
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239

Re: Generating docu in 1.4.3.3.g01929

[Sean]

On Fri, 27 Oct 2006 14:26:53 -0300
"Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:

> I'm getting lots of these after today's pull:
> 
> asciidoc -b docbook -d manpage -f asciidoc.conf git-daemon.txt
> xmlto -m callouts.xsl man git-daemon.xml
> error : unterminated entity reference                
> error : unterminated entity reference                
> error : unterminated entity reference             ...
> error : unterminated entity reference                
> error : unterminated entity reference                
> Writing git-daemon.1 for refentry

Can't reproduce this here on master or on next with:
 asciidoc-7.1.2-0 and xmlto-0.0.18-13.1
Maybe this is an Asciidoc 8 issue, are you using it?

Re: Generating docu in 1.4.3.3.g01929

[Junio C Hamano]

"Horst H. von Brand" <vonbrand@inf.utfsm.cl> writes:

> I'm getting lots of these after today's pull:
>
> asciidoc -b docbook -d manpage -f asciidoc.conf git-daemon.txt
> xmlto -m callouts.xsl man git-daemon.xml
> error : unterminated entity reference                
> error : unterminated entity reference                
> error : unterminated entity reference             ...
> error : unterminated entity reference                
> error : unterminated entity reference                
> Writing git-daemon.1 for refentry

Is it only with git-daemon.txt (as opposed to other files like
git-cat-file.txt), is it only with generating git-daemon.1 (as
opposed to generating git-daemon.html), and is it only with
today's pull (as opposed to 1.4.3.3)?

The point I am getting at is if it is only for you and if so
we might want to pinpoint where the breakage is.

I do not see it with my xmlto and asciidoc combination, either
on FC6 nor on Debian testing.

Re: Generating docu in 1.4.3.3.g01929

[Horst H. von Brand]

Sean <seanlkml@sympatico.ca> wrote:

> On Fri, 27 Oct 2006 14:26:53 -0300
> "Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:
> 
> > I'm getting lots of these after today's pull:
> > 
> > asciidoc -b docbook -d manpage -f asciidoc.conf git-daemon.txt
> > xmlto -m callouts.xsl man git-daemon.xml
> > error : unterminated entity reference                
> > error : unterminated entity reference                
> > error : unterminated entity reference             ...
> > error : unterminated entity reference                
> > error : unterminated entity reference                
> > Writing git-daemon.1 for refentry
> 
> Can't reproduce this here on master or on next with:
>  asciidoc-7.1.2-0 and xmlto-0.0.18-13.1
> Maybe this is an Asciidoc 8 issue, are you using it?

Fedora rawhide i386, with:

  asciidoc-7.0.2-3.fc6
  xmlto-0.0.18-13.1

Perhaps too old, not too new...
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239

Re: Generating docu in 1.4.3.3.g01929

[Sean]

On Fri, 27 Oct 2006 20:12:50 -0300
"Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:

> > > asciidoc -b docbook -d manpage -f asciidoc.conf git-daemon.txt
> > > xmlto -m callouts.xsl man git-daemon.xml
> > > error : unterminated entity reference                
> > > error : unterminated entity reference                
> > > error : unterminated entity reference             ...
> > > error : unterminated entity reference                
> > > error : unterminated entity reference                
> > > Writing git-daemon.1 for refentry
> > 
> > Can't reproduce this here on master or on next with:
> >  asciidoc-7.1.2-0 and xmlto-0.0.18-13.1
> > Maybe this is an Asciidoc 8 issue, are you using it?
> 
> Fedora rawhide i386, with:
> 
>   asciidoc-7.0.2-3.fc6
>   xmlto-0.0.18-13.1
> 
> Perhaps too old, not too new...

Can't imagine that it's too old.  You may have to bisect to figure
out what the culprit is. :o/

Re: Generating docu in 1.4.3.3.g01929

[Junio C Hamano]

Sean <seanlkml@sympatico.ca> writes:

>> > Can't reproduce this here on master or on next with:
>> >  asciidoc-7.1.2-0 and xmlto-0.0.18-13.1
>> > Maybe this is an Asciidoc 8 issue, are you using it?
>> 
>> Fedora rawhide i386, with:
>> 
>>   asciidoc-7.0.2-3.fc6
>>   xmlto-0.0.18-13.1
>> 
>> Perhaps too old, not too new...
>
> Can't imagine that it's too old.  You may have to bisect to figure
> out what the culprit is. :o/

Eh, do you mean bisecting asciidoc?  I am not seeing the problem
with these on a freshly installed FC6:

Name   : asciidoc
Arch   : noarch
Version: 7.0.2
Release: 3.fc6

Name   : xmlto
Arch   : i386
Version: 0.0.18
Release: 13.1

Re: Generating docu in 1.4.3.3.g01929

[Sean]

On Fri, 27 Oct 2006 22:45:51 -0700
Junio C Hamano <junkio@cox.net> wrote:

> Eh, do you mean bisecting asciidoc?  I am not seeing the problem
> with these on a freshly installed FC6:
> 

Yeah.. don't see the problem here either.  But assuming there
is some strange interaction with Horst's environment, bisecting
would narrow it down.  Even though I don't really think bisecting
will turn up a problem in Git, it might identify the problem in
the environment.. 

Re: Generating docu in 1.4.3.3.g01929

[Junio C Hamano]

Sean <seanlkml@sympatico.ca> writes:

> On Fri, 27 Oct 2006 22:45:51 -0700
> Junio C Hamano <junkio@cox.net> wrote:
>
>> Eh, do you mean bisecting asciidoc?  I am not seeing the problem
>> with these on a freshly installed FC6:
>
> Yeah.. don't see the problem here either.  But assuming there
> is some strange interaction with Horst's environment, bisecting
> would narrow it down.  Even though I don't really think bisecting
> will turn up a problem in Git, it might identify the problem in
> the environment.. 

Horst has a non-working combination that is:

 - tip of "master" of the day
 - Fedora rawhide i386 (whatever that is -- sorry I am new to RPM world)
 - asciidoc 7.0.2 3.fc6
 - xmlto 0.0.18 13.1

I have a working combination:

 - tip of "master" of the day
 - FC6 i386 (freshly installed)
 - asciidoc 7.0.2 3.fc6
 - xmlto 0.0.18 13.1

So the difference between me and Horst that can be bisected is
not what are listed above.  I wonder what other things come into
the picture.

"rpm -q --requires" tells us that:

 - asciidoc wants python >= 2.3
 - xmlto wants docbook-dtds, docbook-xsl >= 1.56.0, flex,
   libxslt, passivetex >= 1.11, util-linux, w3m

and here is what I have:

   asciidoc-7.0.2-3.fc6
   xmlto-0.0.18-13.1
   python-2.4.3-18.fc6
   docbook-dtds-1.0-30.1
   package docbook-xsl is not installed
   flex-2.5.4a-41.fc6
   libxslt-1.1.17-1.1
   passivetex-1.25-5.1.1
   util-linux-2.13-0.44.fc6
   w3m-0.5.1-14.1

"rpm -q --whatprovides docbook-xsl" says:

   docbook-style-xsl-1.69.1-5.1

and it is installed on the FC6 box.

Re: Generating docu in 1.4.3.3.g01929

[Sean]

On Sat, 28 Oct 2006 12:04:24 -0700
Junio C Hamano <junkio@cox.net> wrote:

> Horst has a non-working combination that is:
> 
>  - tip of "master" of the day
>  - Fedora rawhide i386 (whatever that is -- sorry I am new to RPM world)
>  - asciidoc 7.0.2 3.fc6
>  - xmlto 0.0.18 13.1
> 
> I have a working combination:
> 
>  - tip of "master" of the day
>  - FC6 i386 (freshly installed)
>  - asciidoc 7.0.2 3.fc6
>  - xmlto 0.0.18 13.1
> 
> So the difference between me and Horst that can be bisected is
> not what are listed above.  I wonder what other things come into
> the picture.

The thing is, Horst implied everything worked before a recent pull.
It's worth at least going back to see if that's true.  Quite likely
that older version will no longer work anymore either, but maybe it
will.  Of course, if an older version no longer works, there's no
need to bisect further, something in the environment has changed.
Either way, it'll help narrow things down a bit.

Re: Generating docu in 1.4.3.3.g01929

[Junio C Hamano]

Sean <seanlkml@sympatico.ca> writes:

>> So the difference between me and Horst that can be bisected is
>> not what are listed above.  I wonder what other things come into
>> the picture.
>
> The thing is, Horst implied everything worked before a recent pull.

Ah, Ok.

I explicitly asked about things that would help to narrow down
and Horst did not answer to any, so I took that "no info" as (0)
this is the first doc generation so it is unknown if older git
sources would generate docs correctly in the environment, (1)
not just git-daemon.1 but generating git-anything.1 is broken,
(2) not just git-daemon.1 but generating git-daemon.html is also
broken.

You interpreted the "no info" differently, which is valid.

> It's worth at least going back to see if that's true.  Quite likely
> that older version will no longer work anymore either, but maybe it
> will.  Of course, if an older version no longer works, there's no
> need to bisect further, something in the environment has changed.
> Either way, it'll help narrow things down a bit.

Very true.

Re: Generating docu in 1.4.3.3.g01929

[Horst H. von Brand]

Junio C Hamano <junkio@cox.net> wrote:

[...]

> and here is what I have:
> 
>    asciidoc-7.0.2-3.fc6
>    xmlto-0.0.18-13.1
>    python-2.4.3-18.fc6
>    docbook-dtds-1.0-30.1
>    package docbook-xsl is not installed
>    flex-2.5.4a-41.fc6
>    libxslt-1.1.17-1.1
>    passivetex-1.25-5.1.1
>    util-linux-2.13-0.44.fc6
>    w3m-0.5.1-14.1

I've got:

asciidoc-7.0.2-3.fc6
xmlto-0.0.18-13.1
python-2.4.4-1.fc7
docbook-dtds-1.0-30.1
package docbook-xsl is not installed
flex-2.5.4a-41.fc6
libxslt-1.1.18-1
passivetex-1.25-5.1.1
util-linux-2.13-0.44.fc6
w3m-0.5.1-14.1

> "rpm -q --whatprovides docbook-xsl" says:
> 
>    docbook-style-xsl-1.69.1-5.1

docbook-style-xsl-1.69.1-5.1

Differences are (mine (Junio's)):

python-2.4.4-1.fc7 (python-2.4.3-18.fc6)
libxslt-1.1.18-1 (libxslt-1.1.17-1.1)

libxslt requires libxml2:

libxml2-2.6.27-1 (Fedora 6 has libxml2-2.6.26-2.1.1)

Getting the Fedora 6 libxslt (Junio's) and redoing git gives no errors.

Judging from the libxslt changelog <http://xmlsoft.org/XSLT/news.html> they
tightened up the processing, so I'd guess asciidoc is generating fishy XML
or xmlto is broken. I've no clue here... somebody knowledgeable who can
take a closer look or otherwise lend me a hand?

Thanks!

PS: I get similar errors with tig...
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513