* git daemon broken?
@ 2005-11-21 6:47 YOSHIFUJI Hideaki / 吉藤英明
2005-11-21 7:30 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2005-11-21 6:47 UTC (permalink / raw)
To: junkio; +Cc: yoshfuji, git
Hello.
It seems that git-daemon is broken.
(On server side)
% git daemon --verbose
(On client side)
% git pull git://git.skbuff.net/gitroot/yoshfuji/x.git
Then, we get on the server side,
:
[16660] Request for '/gitroot/yoshfuji/x.git'
fatal: '.': unable to chdir or not a git archive
[16660] Disconnected (with error)
It works if I remove "--strict" from daemon.c.
% git daemon --verbose
:
[16723] Request for '/gitroot/yoshfuji/x.git'
Packing 21 objects
[16723] Disconnected
--
YOSHIFUJI Hideaki @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG-FP : 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: git daemon broken?
2005-11-21 6:47 git daemon broken? YOSHIFUJI Hideaki / 吉藤英明
@ 2005-11-21 7:30 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2005-11-21 7:30 UTC (permalink / raw)
To: YOSHIFUJI Hideaki / 吉藤英明; +Cc: git
I think this should fix it; the problem analysis I did in my
previous mail was half-baked, and the thing about '||' vs '&&'
was completely faulty. Obviously I am not thinking straight
tonight, so I'll go to bed.
---
diff --git a/path.c b/path.c
index 84b3272..4d88947 100644
--- a/path.c
+++ b/path.c
@@ -181,7 +181,7 @@ char *enter_repo(char *path, int strict)
return NULL;
if (strict) {
- if((path[0] != '/') || chdir(path) < 0)
+ if (chdir(path) < 0)
return NULL;
}
else {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-21 7:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-21 6:47 git daemon broken? YOSHIFUJI Hideaki / 吉藤英明
2005-11-21 7:30 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox