* [PATCH] help -i: properly error out if no info viewer can be found
@ 2009-10-27 13:31 Gerrit Pape
2009-10-28 7:18 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Gerrit Pape @ 2009-10-27 13:31 UTC (permalink / raw)
To: Junio C Hamano, git
With this commit, git help -i <cmd> prints an error message and exits
non-zero instead of being silent and exit code 0.
Reported by Trent W. Buck through
http://bugs.debian.org/537664
Signed-off-by: Gerrit Pape <pape@smarden.org>
---
builtin-help.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-help.c b/builtin-help.c
index e1eba77..e1ade8e 100644
--- a/builtin-help.c
+++ b/builtin-help.c
@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)
const char *page = cmd_to_page(git_cmd);
setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);
execlp("info", "info", "gitman", page, NULL);
+ die("no info viewer handled the request");
}
static void get_html_page_path(struct strbuf *page_path, const char *page)
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-28 7:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-27 13:31 [PATCH] help -i: properly error out if no info viewer can be found Gerrit Pape
2009-10-28 7:18 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox