* [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c
@ 2006-07-28 9:17 Johannes Schindelin
2006-07-28 18:14 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2006-07-28 9:17 UTC (permalink / raw)
To: git, junkio
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
Makefile | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 636679f..e8037ad 100644
--- a/Makefile
+++ b/Makefile
@@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)
$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
$(LIB_FILE) $(SIMPLE_LIB)
+ssh-pull.o: ssh-fetch.c
git-local-fetch$X: fetch.o
git-ssh-fetch$X: rsh.o fetch.o
git-ssh-upload$X: rsh.o
--
1.4.2.rc2.g51ee8-dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c
2006-07-28 9:17 [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c Johannes Schindelin
@ 2006-07-28 18:14 ` Junio C Hamano
2006-07-28 18:55 ` Johannes Schindelin
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2006-07-28 18:14 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
> Makefile | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 636679f..e8037ad 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -661,6 +661,7 @@ git-%$X: %.o $(GITLIBS)
> $(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
> $(LIB_FILE) $(SIMPLE_LIB)
>
> +ssh-pull.o: ssh-fetch.c
> git-local-fetch$X: fetch.o
> git-ssh-fetch$X: rsh.o fetch.o
> git-ssh-upload$X: rsh.o
My personal preference would be to deprecate these commit
walkers ;-) but in any case we would also need to make
ssh-push.o depend on ssh-upload.c for the same logic.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c
2006-07-28 18:14 ` Junio C Hamano
@ 2006-07-28 18:55 ` Johannes Schindelin
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Schindelin @ 2006-07-28 18:55 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Hi,
On Fri, 28 Jul 2006, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > +ssh-pull.o: ssh-fetch.c
>
> My personal preference would be to deprecate these commit walkers ;-)
> but in any case we would also need to make ssh-push.o depend on
> ssh-upload.c for the same logic.
Probably. But this was a _necessary_ fix: git stopped compiling here (yes,
I could have done "make clean && make", but that takes all the fun out of
it...).
Ciao,
Dscho
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-07-28 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-28 9:17 [PATCH] Makefile: ssh-pull.o depends on ssh-fetch.c Johannes Schindelin
2006-07-28 18:14 ` Junio C Hamano
2006-07-28 18:55 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox