From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: [PATCH - maint review] describe: do not silently ignore indescribable commits
Date: Wed, 11 Jan 2006 16:05:05 -0800 [thread overview]
Message-ID: <7vu0cajopa.fsf@assigned-by-dhcp.cox.net> (raw)
We silently ignored indescribable commits without complaining.
Complain and die instead.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
* For 1.1.2
describe.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
8c23b6fae2e5cd8475885b015f0bb992d19921db
diff --git a/describe.c b/describe.c
index a0180f5..5548a16 100644
--- a/describe.c
+++ b/describe.c
@@ -124,10 +124,11 @@ static void describe(struct commit *cmit
if (n) {
printf("%s-g%s\n", n->path,
find_unique_abbrev(cmit->object.sha1, abbrev));
- break;
+ clear_commit_marks(cmit, SEEN);
+ return;
}
}
- clear_commit_marks(cmit, SEEN);
+ die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
}
int main(int argc, char **argv)
--
1.1.1-g8ecb
reply other threads:[~2006-01-12 0:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vu0cajopa.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox