* [PATCH - maint review] describe: do not silently ignore indescribable commits
@ 2006-01-12 0:05 Junio C Hamano
0 siblings, 0 replies; only message in thread
From: Junio C Hamano @ 2006-01-12 0:05 UTC (permalink / raw)
To: git
We silently ignored indescribable commits without complaining.
Complain and die instead.
Signed-off-by: Junio C Hamano <junkio@cox.net>
---
* For 1.1.2
describe.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
8c23b6fae2e5cd8475885b015f0bb992d19921db
diff --git a/describe.c b/describe.c
index a0180f5..5548a16 100644
--- a/describe.c
+++ b/describe.c
@@ -124,10 +124,11 @@ static void describe(struct commit *cmit
if (n) {
printf("%s-g%s\n", n->path,
find_unique_abbrev(cmit->object.sha1, abbrev));
- break;
+ clear_commit_marks(cmit, SEEN);
+ return;
}
}
- clear_commit_marks(cmit, SEEN);
+ die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1));
}
int main(int argc, char **argv)
--
1.1.1-g8ecb
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-01-12 0:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-12 0:05 [PATCH - maint review] describe: do not silently ignore indescribable commits Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox