From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] add receive.denyNonFastforwards config variable
Date: Wed, 20 Sep 2006 22:35:13 -0700 [thread overview]
Message-ID: <7vzmctdbou.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0609210206320.19042@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Thu, 21 Sep 2006 02:07:19 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> On Wed, 20 Sep 2006, Jeff King wrote:
>
>> Memory leak on 'bases'. It shouldn't matter much because the program is
>> short-lived, but I couldn't remember if we have a policy on such things
>> with increasing lib-ification.
>
> True. How about this:
>
> -- snip --
>
> + backup = get_merge_bases(old_commit, new_commit, 1);
> + for (bases = backup;
> bases; bases = bases->next)
> if (!hashcmp(old_sha1, bases->item->object.sha1))
> break;
> if (!bases)
> return error("denying non-fast forward;"
> " you should pull first");
> + free_commit_list(backup);
Still leaking on the error path ;-).
Will fixup and apply; no need to resend.
prev parent reply other threads:[~2006-09-21 5:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 22:28 [PATCH] add receive.denyNonFastforwards config variable Johannes Schindelin
2006-09-20 22:44 ` Junio C Hamano
2006-09-20 22:46 ` Shawn Pearce
2006-09-20 23:07 ` Johannes Schindelin
2006-09-20 23:19 ` Junio C Hamano
2006-09-21 0:10 ` Johannes Schindelin
2006-09-21 6:26 ` Junio C Hamano
2006-09-21 9:10 ` Johannes Schindelin
2006-09-20 23:38 ` Junio C Hamano
2006-09-21 0:17 ` Johannes Schindelin
2006-09-21 5:08 ` Junio C Hamano
2006-09-21 5:52 ` Jeff King
2006-09-21 6:43 ` Junio C Hamano
2006-09-21 9:08 ` Johannes Schindelin
2006-09-21 9:25 ` Junio C Hamano
2006-09-20 23:45 ` Jeff King
2006-09-21 0:07 ` Johannes Schindelin
2006-09-21 5:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vzmctdbou.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox