Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [BUG] Add a test to check git-prune does not throw away revs hidden by a graft.
Date: Thu, 18 May 2006 15:36:39 -0700	[thread overview]
Message-ID: <7vzmhfm03s.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060518222045.GB6535@nowhere.earth> (Yann Dirson's message of "Fri, 19 May 2006 00:20:45 +0200")

Yann Dirson <ydirson@altern.org> writes:

> I'm not sure I understand what you're saying.

Please don't; I was asleep when I typed it -- sorry.

I was hoping fsck was doing the right thing for a very low level
tool -- verify commit objects itself, without relying on the
object parser machinery which does funky things like grafts.

Apparently it doesn't -- which is mostly good.  You can safely
remove commits you wanted to discard by grafting it away like
your test did, and you can keep unrelated history you grafted to
the back of your real root commit.

For the "clone without propagating grafts" issue, I think we
need to have a way to communicate grafts across repositories.
As you say, grafts is a local policy issue, but when you start
cloning you _are_ sharing that local policy across repositories.
Futzing fsck to honor and ignore grafts at the same time sounds
like a band-aid to me.

  reply	other threads:[~2006-05-18 22:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18 21:35 [PATCH] [BUG] Add a test to check git-prune does not throw away revs hidden by a graft Yann Dirson
2006-05-18 21:37 ` Linus Torvalds
2006-05-18 21:46   ` Junio C Hamano
2006-05-18 22:01     ` Linus Torvalds
2006-05-18 22:25       ` Junio C Hamano
2006-05-18 22:20     ` Yann Dirson
2006-05-18 22:36       ` Junio C Hamano [this message]
2006-05-18 22:52       ` Yann Dirson
2006-05-18 22:53         ` Junio C Hamano
2006-05-19 18:55           ` Yann Dirson
2006-05-19 19:00             ` Jakub Narebski
2006-05-19 19:02             ` Linus Torvalds
2006-05-19 20:25               ` Yann Dirson
2006-05-19 20:45                 ` Linus Torvalds
2006-05-19 22:22               ` Junio C Hamano
2006-05-19 22:26               ` [PATCH] [BUG] Add a test to check git-prune does not throw awayrevs " David Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzmhfm03s.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=ydirson@altern.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox