From: David Kastrup <dak@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands
Date: Thu, 02 Aug 2007 01:58:14 +0200 [thread overview]
Message-ID: <85sl72x0x5.fsf@lola.goethe.zz> (raw)
In-Reply-To: <7vtzri3kpr.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Wed\, 01 Aug 2007 16\:21\:04 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> It is not just "won't apply". What if GIT_DIR had spaces (which
>> is fine) and single-quotes in it? Wouldn't it percolate down to
>> $@ because it becomes the leading directory of the temporary
>> file name? And you quote '"$@"' and eval it, now what happens?
>
> Ah, I spoke too fast. It is fine --- the shell that actually is
> doing the eval then interpolates "$@". Clever.
Since eval folds all its arguments into a single string separated by
single blanks, actual blanks (which can be multiple or interspersed
with newlines) must not yet be seen. The string '"$@"' contains no
blanks and thus gets through unmolested.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-08-01 23:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 13:36 Interpreting EDITOR/VISUAL environment variables David Kastrup
2007-08-01 17:12 ` Junio C Hamano
2007-08-01 18:50 ` Yann Dirson
2007-08-01 19:30 ` David Kastrup
2007-08-01 19:08 ` David Kastrup
2007-08-01 19:53 ` Junio C Hamano
2007-08-01 21:47 ` [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands David Kastrup
2007-08-01 22:17 ` David Kastrup
2007-08-01 21:47 ` David Kastrup
2007-08-01 23:18 ` Junio C Hamano
2007-08-01 23:21 ` Junio C Hamano
2007-08-01 23:58 ` David Kastrup [this message]
2007-08-02 1:00 ` Junio C Hamano
2007-08-01 23:55 ` David Kastrup
2007-08-02 10:10 ` Interpreting EDITOR/VISUAL environment variables Matthias Lederhofer
2007-08-02 10:31 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85sl72x0x5.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox