From: Junio C Hamano <gitster@pobox.com>
To: David Kastrup <dak@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands
Date: Wed, 01 Aug 2007 16:18:14 -0700 [thread overview]
Message-ID: <7vy7gu3kuh.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <85ejimrjb2.fsf@lola.goethe.zz> (David Kastrup's message of "Thu, 02 Aug 2007 00:17:37 +0200")
David Kastrup <dak@gnu.org> writes:
> David Kastrup <dak@gnu.org> writes:
>
>> The previous code only allowed specifying a single executable rather
>> than a complete command like "emacsclient --alternate-editor vi" in
>
> Oops, won't apply cleanly. I found that I had already made a
> different (trivial) patch previously. Let me try again and fold that
> patch in manually.
It is not just "won't apply". What if GIT_DIR had spaces (which
is fine) and single-quotes in it? Wouldn't it percolate down to
$@ because it becomes the leading directory of the temporary
file name? And you quote '"$@"' and eval it, now what happens?
next prev parent reply other threads:[~2007-08-01 23:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 13:36 Interpreting EDITOR/VISUAL environment variables David Kastrup
2007-08-01 17:12 ` Junio C Hamano
2007-08-01 18:50 ` Yann Dirson
2007-08-01 19:30 ` David Kastrup
2007-08-01 19:08 ` David Kastrup
2007-08-01 19:53 ` Junio C Hamano
2007-08-01 21:47 ` [PATCH] git-sh-setup.sh: make GIT_EDITOR/core.editor/VISUAL/EDITOR accept commands David Kastrup
2007-08-01 22:17 ` David Kastrup
2007-08-01 21:47 ` David Kastrup
2007-08-01 23:18 ` Junio C Hamano [this message]
2007-08-01 23:21 ` Junio C Hamano
2007-08-01 23:58 ` David Kastrup
2007-08-02 1:00 ` Junio C Hamano
2007-08-01 23:55 ` David Kastrup
2007-08-02 10:10 ` Interpreting EDITOR/VISUAL environment variables Matthias Lederhofer
2007-08-02 10:31 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vy7gu3kuh.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox