Re: [PATCH v4 2/5] builtin/refs: add "delete" subcommand

[Toon Claes <toon@iotcl.com>]

Patrick Steinhardt <ps@pks.im> writes:

> +test_expect_success 'delete symref with --no-deref verifies target OID' '
> +	test_when_finished "rm -rf repo" &&
> +	setup_repo repo &&
> +	(
> +		cd repo &&
> +		A=$(git rev-parse A) &&
> +		B=$(git rev-parse B) &&
> +		git update-ref refs/heads/foo $A &&
> +		git symbolic-ref refs/heads/symref refs/heads/foo &&
> +
> +		test_must_fail git refs delete --no-deref refs/heads/symref $B &&
> +		git refs exists refs/heads/symref &&
> +
> +		git refs delete --no-deref refs/heads/symref $A &&
> +		test_must_fail git refs exists refs/heads/symref &&
> +		git refs exists refs/heads/foo
> +	)

So with --no-deref it still checks the dererenced OID, not the target
ref? I expected it to work like this:

    test_expect_success 'delete symref with --no-deref verifies target ref' '
            test_when_finished "rm -rf repo" &&
            setup_repo repo &&
            (
                    cd repo &&
                    A=$(git rev-parse A) &&
                    B=$(git rev-parse B) &&
                    git update-ref refs/heads/foo $A &&
                    git symbolic-ref refs/heads/symref refs/heads/foo &&

                    test_must_fail git refs delete --no-deref refs/heads/symref refs/heads/bar &&
                    git refs exists refs/heads/symref &&

                    git refs delete --no-deref refs/heads/symref refs/heads/foo &&
                    test_must_fail git refs exists refs/heads/symref &&
                    git refs exists refs/heads/foo
            )


-- 
Cheers,
Toon