From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] Improve performance of reflog expiration
Date: Wed, 18 Nov 2026 16:56:57 +0100 [thread overview]
Message-ID: <87bj7mjfp2.fsf@dev.null.iotcl.com.invalid> (raw)
In-Reply-To: <20261118-pks-reflog-expire-performance-v1-0-10b9263566a8@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
> Hi,
>
> I recently noticed that a bunch of commands started hanging for almost a
> second after they're essentially done already. As it turns out, this was
> caused by auto-maintenance, which was blocking in the foreground for
> ~800ms.
>
> The root cause of this is that the auto-condition of "reflog-expire"
> doesn't properly evaluate reachability of reflog entries, so it instead
> considered every single reflog entry to point to an unreachable commit.
> Hence, all entries were evaluated against "gc.reflogExpireUnreachable"
> instead of "gc.reflogExpire", and thus the auto-condition significantly
> overcounts the number of entries that we'd prune. So every single run of
> git-maintenance(1) ultimately ended up spawning `git reflog expire`.
>
> This is fixed by the last patch in this series.
Well, the last one is a doc change, but I get what you mean.
> But I was a bit
> surprised that a no-op `git reflog expire` took this long, so the first
> two patches optimize the reftable backend to be more efficient, too.
> In my copy of "git.git":
>
> Benchmark 1: git maintenance run --auto (commit = master) (10 runs)
> mean ± σ min … max
> Wall Time 853.2 ms ± 99.9 ms 570.9 ms … 901.9 ms
> Memory 117.5 MiB ± 0.3 MiB 117.2 MiB … 118.2 MiB
>
> Benchmark 2: git maintenance run --auto (commit = reftable-optimizations) (10 runs)
> mean ± σ min … max
> Wall Time 392.3 ms ± 2.3 ms 388.0 ms … 396.6 ms -54.0% (2.2x faster)
> Memory 117.2 MiB ± 0.2 MiB 116.8 MiB … 117.4 MiB -0.2%
>
> Benchmark 3: git maintenance run --auto (commit = auto-condition-optimizations) (10 runs)
> mean ± σ min … max
> Wall Time 18.6 ms ± 1.1 ms 17.4 ms … 20.9 ms -97.8% (45.8x faster)
> Memory 81.2 MiB ± 0.1 MiB 80.9 MiB … 81.4 MiB -30.9% (1.4x less)
>
> So yeah, it's a bit more efficient now. :)
Great work. I only had one remark on consistency, but not really worth a
reroll in itself if you ask me.
--
Laters,
Toon
prev parent reply other threads:[~2026-11-18 15:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:30 [PATCH 0/4] Improve performance of reflog expiration Patrick Steinhardt
2026-11-18 9:31 ` [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Patrick Steinhardt
2026-11-18 11:28 ` Karthik Nayak
2026-11-18 12:05 ` Patrick Steinhardt
2026-11-18 16:51 ` Junio C Hamano
2026-11-18 9:31 ` [PATCH 2/4] refs/reftable: don't write new table when expire is a no-op Patrick Steinhardt
2026-11-18 11:33 ` Karthik Nayak
2026-11-18 12:05 ` Patrick Steinhardt
2026-11-18 15:34 ` Toon Claes
2026-11-18 9:31 ` [PATCH 3/4] builtin/maintenance: only consider `gc.reflogExpire` for "--auto" Patrick Steinhardt
2026-11-18 15:52 ` Toon Claes
2026-11-18 9:31 ` [PATCH 4/4] Documentation/config: fix typo in "maintenance.reflog-expire.auto" Patrick Steinhardt
2026-11-18 15:54 ` Toon Claes
2026-11-18 15:56 ` Toon Claes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bj7mjfp2.fsf@dev.null.iotcl.com.invalid \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox