From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] refs/reftable: don't write new table on dry-run expire
Date: Wed, 18 Nov 2026 08:51:41 -0800 [thread overview]
Message-ID: <xmqq1p8i84ma.fsf@gitster.g> (raw)
In-Reply-To: <20261118-pks-reflog-expire-performance-v1-1-10b9263566a8@pks.im> (Patrick Steinhardt's message of "Wed, 18 Nov 2026 10:31:00 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> The `git reflog expire` subcommand supports a dry-run flag. When set, we
> print what would be pruned without actually pruning anything on disk.
>
> But even though the expectation is that the on-disk state won't change,
> the reftable backend still ends up writing a new reftable to disk that
> contains the changes. This is of course rather pointless, as we would
> have already printed the entries that we're about to prune at that point
> in time.
I hope I am right in assuming that the current code already has
provisions to discard (or "not to use") this data written to the
disk. If so, that means --dry-run is working correctly, and this
change is a performance-only improvement. Is that the untold piece
of information here?
> Skip writing the data, which provides a small speedup:
>
> Benchmark 1: git reflog expire --all --dry-run (commit = HEAD~) (10 runs)
> mean ± σ min … max
> Wall Time 414.2 ms ± 2.2 ms 411.8 ms … 418.0 ms
> Memory 116.9 MiB ± 0.1 MiB 116.6 MiB … 117.0 MiB
>
> Benchmark 2: git reflog expire --all --dry-run (commit = HEAD) (10 runs)
> mean ± σ min … max
> Wall Time 369.1 ms ± 3.2 ms 361.9 ms … 371.9 ms -10.9%
> Memory 116.8 MiB ± 0.1 MiB 116.7 MiB … 117.0 MiB -0.1%
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> refs/reftable-backend.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c
> index 3ba6a9ac0db..4216a18684d 100644
> --- a/refs/reftable-backend.c
> +++ b/refs/reftable-backend.c
> @@ -2706,6 +2706,11 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
> if (flags & EXPIRE_REFLOGS_UPDATE_REF && last_hash && !is_null_oid(&oid))
> oidread(&arg.update_oid, last_hash, ref_store->repo->hash_algo);
>
> + if ((flags & EXPIRE_REFLOGS_DRY_RUN)) {
> + ret = 0;
> + goto done;
> + }
> +
> arg.refs = refs;
> arg.records = rewritten;
> arg.len = logs_nr;
> @@ -2720,8 +2725,7 @@ static int reftable_be_reflog_expire(struct ref_store *ref_store,
> * Future improvement: we could skip writing records that were
> * not changed.
> */
> - if (!(flags & EXPIRE_REFLOGS_DRY_RUN))
> - ret = reftable_addition_commit(add);
> + ret = reftable_addition_commit(add);
>
> done:
> if (add)
next prev parent reply other threads:[~2026-11-18 16:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:30 [PATCH 0/4] Improve performance of reflog expiration Patrick Steinhardt
2026-11-18 9:31 ` [PATCH 1/4] refs/reftable: don't write new table on dry-run expire Patrick Steinhardt
2026-11-18 11:28 ` Karthik Nayak
2026-11-18 12:05 ` Patrick Steinhardt
2026-11-18 16:51 ` Junio C Hamano [this message]
2026-11-18 9:31 ` [PATCH 2/4] refs/reftable: don't write new table when expire is a no-op Patrick Steinhardt
2026-11-18 11:33 ` Karthik Nayak
2026-11-18 12:05 ` Patrick Steinhardt
2026-11-18 15:34 ` Toon Claes
2026-11-18 9:31 ` [PATCH 3/4] builtin/maintenance: only consider `gc.reflogExpire` for "--auto" Patrick Steinhardt
2026-11-18 15:52 ` Toon Claes
2026-11-18 9:31 ` [PATCH 4/4] Documentation/config: fix typo in "maintenance.reflog-expire.auto" Patrick Steinhardt
2026-11-18 15:54 ` Toon Claes
2026-11-18 15:56 ` [PATCH 0/4] Improve performance of reflog expiration Toon Claes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1p8i84ma.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox