[BUG] git-web unable to show this commit properly?

[BUG] git-web unable to show this commit properly?

[Dexuan Cui]

Hi,
"git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb --stat" shows the below:

commit 122333d6bd229af279cdb35d1b874b71b3b9ccfb
Author: Nikolay Borisov <nik.borisov@suse.com>
Date:   Fri May 5 15:03:32 2023 +0300

    x86/tdx: Wrap exit reason with hcall_func()

    TDX reuses VMEXIT "reasons" in its guest->host hypercall ABI.  This is
    confusing because there might not be a VMEXIT involved at *all*.
    These instances are supposed to document situation and reduce confusion
    by wrapping VMEXIT reasons with hcall_func().

    The decompression code does not follow this convention.

    Unify the TDX decompression code with the other TDX use of VMEXIT reasons.
    No functional changes.

    Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
    Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
    Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Link: https://lore.kernel.org/all/20230505120332.1429957-1-nik.borisov%40suse.com

 arch/x86/boot/compressed/tdx.c    |  4 ++--
 arch/x86/coco/tdx/tdx.c           | 11 -----------
 arch/x86/include/asm/shared/tdx.h | 11 +++++++++++
 3 files changed, 13 insertions(+), 13 deletions(-)

But the web interface only shows " 1 files changed, 0 insertions, 11 deletions" 
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/coco?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb
(Note: the correct info should be "3 files changed, 13 insertions(+), 13 deletions(-)", as shown above by git-show)

Looks like this may have something to do with Rename Detection? But IMO the
web interface should at least show "3 files changed", otherwise it's confusing...

Thanks,
-- Dexuan

Re: [BUG] git-web unable to show this commit properly?

[Andreas Schwab]

On Jun 19 2023, Dexuan Cui wrote:

> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/arch/x86/coco?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb

That URL corresponds to this command:

git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb -- arch/x86/coco

If you want to see the whole commit, use
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit?id=122333d6bd229af279cdb35d1b874b71b3b9ccfb

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

RE: [BUG] git-web unable to show this commit properly?

[Dexuan Cui]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Sent: Monday, June 19, 2023 3:01 PM
> To: Dexuan Cui <decui@microsoft.com>
> Cc: 'git@vger.kernel.org' <git@vger.kernel.org>
> Subject: Re: [BUG] git-web unable to show this commit properly?
> 
> [You don't often get email from schwab@linux-m68k.org. Learn why this is
> important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> On Jun 19 2023, Dexuan Cui wrote:
>  ...
> That URL corresponds to this command:
> 
> git show 122333d6bd229af279cdb35d1b874b71b3b9ccfb -- arch/x86/coco

Oh, silly me! :-) I was checking the git-log for the folder from the web interface
and forgot I was checking that folder only.

Thanks for pointing this out!